You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2010/04/26 19:12:17 UTC
Re: [vote] release wicket 1.4.8
this vote is to release wicket 1.4.8
this maintenance release brings over 20 bug fixes and improvements.
branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/
changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
(and below)
vote ends Thursday 11am gmt-8
cheers
-igor
Release Notes - Wicket - Version 1.4.8
** Bug
* [WICKET-2075] - Pagemap is locked forever with some Page
serialization exceptions
* [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
* [WICKET-2764] - MarkupCache messed up when using MergedMarkup
(e.g. for Page markup inheritance) together with IResourceStreams that
do NOT also implement IFixedLocationResourceStream
* [WICKET-2767] - DatePicker Calendar: wrong year format when 4
digits are used (yyyy), e.g. 2010 --> 0010
* [WICKET-2772] - Generate wicketpath attribute for RadioChoice
* [WICKET-2779] - Submit a nested form via ajax to upload a file
inside modal window does not work on IE.
* [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
returns false for non-existing keys, instead of the defaultValue
* [WICKET-2799] - @RequireHttps not switching to https when
setting response page to non-bookmarkable page
* [WICKET-2802] - StringIndexOutOfBoundsException in
PortletServletRequestWrapper for some resource requests
* [WICKET-2806] - Javascript looking for related radio in group is
not working if css class is already assigned to radio
* [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
** Improvement
* [WICKET-2771] - Please support "isPrimary" for @SpringBean
* [WICKET-2776] - Enhancing RadioChoice input items with
individual title and css class attributes
* [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
* [WICKET-2796] - Improve error reporting on locked page maps
* [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
IModel<? extends Collection<T>>
* [WICKET-2813] - IndicatingAjaxButton should have construtors
that take a IModel for the button text as does AjaxButton.
* [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
extends Collection<T>>
* [WICKET-2821] - More "IModel<? extends Collection<" Fixes
* [WICKET-2830] - Make
BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
* [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
* [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
** Wish
* [WICKET-2847] - Make StringResourceStream non final
Re: [vote] release wicket 1.4.8
Posted by Igor Vaynberg <ig...@gmail.com>.
+1
i always forget to add my vote after i send the vote email... :)
-igor
On Thu, Apr 29, 2010 at 11:22 AM, Jeremy Thomerson
<je...@wickettraining.com> wrote:
> Sad that it's been three days and there hasn't been a single vote. I just
> now had the opportunity to upgrade a small demo app to 1.4.8 and it all
> seemed to work fine.
>
> +1 - release
>
> --
> Jeremy Thomerson
> http://www.wickettraining.com
>
>
>
> On Mon, Apr 26, 2010 at 12:12 PM, Igor Vaynberg <ig...@gmail.com>wrote:
>
>> this vote is to release wicket 1.4.8
>>
>> this maintenance release brings over 20 bug fixes and improvements.
>>
>> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
>>
>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/
>>
>> changelog:
>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
>> (and below)
>>
>> vote ends Thursday 11am gmt-8
>>
>> cheers
>>
>> -igor
>>
>>
>> Release Notes - Wicket - Version 1.4.8
>>
>>
>> ** Bug
>> * [WICKET-2075] - Pagemap is locked forever with some Page
>> serialization exceptions
>> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
>> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
>> (e.g. for Page markup inheritance) together with IResourceStreams that
>> do NOT also implement IFixedLocationResourceStream
>> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
>> digits are used (yyyy), e.g. 2010 --> 0010
>> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
>> * [WICKET-2779] - Submit a nested form via ajax to upload a file
>> inside modal window does not work on IE.
>> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
>> returns false for non-existing keys, instead of the defaultValue
>> * [WICKET-2799] - @RequireHttps not switching to https when
>> setting response page to non-bookmarkable page
>> * [WICKET-2802] - StringIndexOutOfBoundsException in
>> PortletServletRequestWrapper for some resource requests
>> * [WICKET-2806] - Javascript looking for related radio in group is
>> not working if css class is already assigned to radio
>> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
>>
>> ** Improvement
>> * [WICKET-2771] - Please support "isPrimary" for @SpringBean
>> * [WICKET-2776] - Enhancing RadioChoice input items with
>> individual title and css class attributes
>> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
>> * [WICKET-2796] - Improve error reporting on locked page maps
>> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
>> IModel<? extends Collection<T>>
>> * [WICKET-2813] - IndicatingAjaxButton should have construtors
>> that take a IModel for the button text as does AjaxButton.
>> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
>> extends Collection<T>>
>> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
>> * [WICKET-2830] - Make
>> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
>> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
>> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
>>
>> ** Wish
>> * [WICKET-2847] - Make StringResourceStream non final
>>
>
Re: [vote] release wicket 1.4.8
Posted by Jeremy Thomerson <je...@wickettraining.com>.
Sad that it's been three days and there hasn't been a single vote. I just
now had the opportunity to upgrade a small demo app to 1.4.8 and it all
seemed to work fine.
+1 - release
--
Jeremy Thomerson
http://www.wickettraining.com
On Mon, Apr 26, 2010 at 12:12 PM, Igor Vaynberg <ig...@gmail.com>wrote:
> this vote is to release wicket 1.4.8
>
> this maintenance release brings over 20 bug fixes and improvements.
>
> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
>
> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/
>
> changelog:
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
> (and below)
>
> vote ends Thursday 11am gmt-8
>
> cheers
>
> -igor
>
>
> Release Notes - Wicket - Version 1.4.8
>
>
> ** Bug
> * [WICKET-2075] - Pagemap is locked forever with some Page
> serialization exceptions
> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
> (e.g. for Page markup inheritance) together with IResourceStreams that
> do NOT also implement IFixedLocationResourceStream
> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
> digits are used (yyyy), e.g. 2010 --> 0010
> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
> * [WICKET-2779] - Submit a nested form via ajax to upload a file
> inside modal window does not work on IE.
> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
> returns false for non-existing keys, instead of the defaultValue
> * [WICKET-2799] - @RequireHttps not switching to https when
> setting response page to non-bookmarkable page
> * [WICKET-2802] - StringIndexOutOfBoundsException in
> PortletServletRequestWrapper for some resource requests
> * [WICKET-2806] - Javascript looking for related radio in group is
> not working if css class is already assigned to radio
> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
>
> ** Improvement
> * [WICKET-2771] - Please support "isPrimary" for @SpringBean
> * [WICKET-2776] - Enhancing RadioChoice input items with
> individual title and css class attributes
> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
> * [WICKET-2796] - Improve error reporting on locked page maps
> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
> IModel<? extends Collection<T>>
> * [WICKET-2813] - IndicatingAjaxButton should have construtors
> that take a IModel for the button text as does AjaxButton.
> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
> extends Collection<T>>
> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
> * [WICKET-2830] - Make
> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
>
> ** Wish
> * [WICKET-2847] - Make StringResourceStream non final
>
Re: [vote] release wicket 1.4.8
Posted by Igor Vaynberg <ig...@gmail.com>.
we go through this every time, and the short answer is: wait for the
next release. if you need it asap then build yourself a snapshot and
use that. personally i dont feel like spending half my day going
through the motions again, building a snapshot is a lot simpler and a
hell of a lot quicker then doing a full release.
-igor
On Mon, Apr 26, 2010 at 12:40 PM, Alex Objelean <al...@gmail.com> wrote:
>
> Could you, please, include WICKET-2846 into 1.4.8? I would need it ASAP.
>
> Thanks!
> Alex
> --
> View this message in context: http://apache-wicket.1842946.n4.nabble.com/Re-vote-release-wicket-1-4-8-tp2065468p2065689.html
> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>
Re: [vote] release wicket 1.4.8
Posted by Alex Objelean <al...@gmail.com>.
Could you, please, include WICKET-2846 into 1.4.8? I would need it ASAP.
Thanks!
Alex
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/Re-vote-release-wicket-1-4-8-tp2065468p2065689.html
Sent from the Wicket - Dev mailing list archive at Nabble.com.
Re: [vote] release wicket 1.4.8
Posted by Martin Grigorov <mc...@e-card.bg>.
Please, port your fixes in 1.5 as well.
Thanks!
On Tue, 2010-04-27 at 15:53 +0200, Johan Compagner wrote:
> I checked today 2 little things in that i would like to have in the next
> build
> one of this is a small regression from: WICKET-1825
>
> The other is a small fix for the patch that i did yesterday for modal
> window.
>
>
> On Mon, Apr 26, 2010 at 19:12, Igor Vaynberg <ig...@gmail.com>wrote:
>
> > this vote is to release wicket 1.4.8
> >
> > this maintenance release brings over 20 bug fixes and improvements.
> >
> > branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
> >
> > artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/<http://people.apache.org/%7Eivaynberg/wicket-1.4.8/>
> >
> > changelog:
> > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
> > (and below)
> >
> > vote ends Thursday 11am gmt-8
> >
> > cheers
> >
> > -igor
> >
> >
> > Release Notes - Wicket - Version 1.4.8
> >
> >
> > ** Bug
> > * [WICKET-2075] - Pagemap is locked forever with some Page
> > serialization exceptions
> > * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
> > * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
> > (e.g. for Page markup inheritance) together with IResourceStreams that
> > do NOT also implement IFixedLocationResourceStream
> > * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
> > digits are used (yyyy), e.g. 2010 --> 0010
> > * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
> > * [WICKET-2779] - Submit a nested form via ajax to upload a file
> > inside modal window does not work on IE.
> > * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
> > returns false for non-existing keys, instead of the defaultValue
> > * [WICKET-2799] - @RequireHttps not switching to https when
> > setting response page to non-bookmarkable page
> > * [WICKET-2802] - StringIndexOutOfBoundsException in
> > PortletServletRequestWrapper for some resource requests
> > * [WICKET-2806] - Javascript looking for related radio in group is
> > not working if css class is already assigned to radio
> > * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
> >
> > ** Improvement
> > * [WICKET-2771] - Please support "isPrimary" for @SpringBean
> > * [WICKET-2776] - Enhancing RadioChoice input items with
> > individual title and css class attributes
> > * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
> > * [WICKET-2796] - Improve error reporting on locked page maps
> > * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
> > IModel<? extends Collection<T>>
> > * [WICKET-2813] - IndicatingAjaxButton should have construtors
> > that take a IModel for the button text as does AjaxButton.
> > * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
> > extends Collection<T>>
> > * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
> > * [WICKET-2830] - Make
> > BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
> > * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
> > * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
> >
> > ** Wish
> > * [WICKET-2847] - Make StringResourceStream non final
> >
Re: [vote] release wicket 1.4.8
Posted by Johan Compagner <jc...@gmail.com>.
I checked today 2 little things in that i would like to have in the next
build
one of this is a small regression from: WICKET-1825
The other is a small fix for the patch that i did yesterday for modal
window.
On Mon, Apr 26, 2010 at 19:12, Igor Vaynberg <ig...@gmail.com>wrote:
> this vote is to release wicket 1.4.8
>
> this maintenance release brings over 20 bug fixes and improvements.
>
> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
>
> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/<http://people.apache.org/%7Eivaynberg/wicket-1.4.8/>
>
> changelog:
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
> (and below)
>
> vote ends Thursday 11am gmt-8
>
> cheers
>
> -igor
>
>
> Release Notes - Wicket - Version 1.4.8
>
>
> ** Bug
> * [WICKET-2075] - Pagemap is locked forever with some Page
> serialization exceptions
> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
> (e.g. for Page markup inheritance) together with IResourceStreams that
> do NOT also implement IFixedLocationResourceStream
> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
> digits are used (yyyy), e.g. 2010 --> 0010
> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
> * [WICKET-2779] - Submit a nested form via ajax to upload a file
> inside modal window does not work on IE.
> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
> returns false for non-existing keys, instead of the defaultValue
> * [WICKET-2799] - @RequireHttps not switching to https when
> setting response page to non-bookmarkable page
> * [WICKET-2802] - StringIndexOutOfBoundsException in
> PortletServletRequestWrapper for some resource requests
> * [WICKET-2806] - Javascript looking for related radio in group is
> not working if css class is already assigned to radio
> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
>
> ** Improvement
> * [WICKET-2771] - Please support "isPrimary" for @SpringBean
> * [WICKET-2776] - Enhancing RadioChoice input items with
> individual title and css class attributes
> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
> * [WICKET-2796] - Improve error reporting on locked page maps
> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
> IModel<? extends Collection<T>>
> * [WICKET-2813] - IndicatingAjaxButton should have construtors
> that take a IModel for the button text as does AjaxButton.
> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
> extends Collection<T>>
> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
> * [WICKET-2830] - Make
> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
>
> ** Wish
> * [WICKET-2847] - Make StringResourceStream non final
>
Re: [vote] release wicket 1.4.8
Posted by Martijn Dashorst <ma...@gmail.com>.
My belated +1
On Fri, Apr 30, 2010 at 6:36 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> the vote is now closed and has passed with two +1 votes. i will upload
> the artifacts to the mirrors and get the ball rolling on the rest.
>
> cheers
> -igor
>
> On Mon, Apr 26, 2010 at 10:12 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>> this vote is to release wicket 1.4.8
>>
>> this maintenance release brings over 20 bug fixes and improvements.
>>
>> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
>>
>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/
>>
>> changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
>> (and below)
>>
>> vote ends Thursday 11am gmt-8
>>
>> cheers
>>
>> -igor
>>
>>
>> Release Notes - Wicket - Version 1.4.8
>>
>>
>> ** Bug
>> * [WICKET-2075] - Pagemap is locked forever with some Page
>> serialization exceptions
>> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
>> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
>> (e.g. for Page markup inheritance) together with IResourceStreams that
>> do NOT also implement IFixedLocationResourceStream
>> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
>> digits are used (yyyy), e.g. 2010 --> 0010
>> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
>> * [WICKET-2779] - Submit a nested form via ajax to upload a file
>> inside modal window does not work on IE.
>> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
>> returns false for non-existing keys, instead of the defaultValue
>> * [WICKET-2799] - @RequireHttps not switching to https when
>> setting response page to non-bookmarkable page
>> * [WICKET-2802] - StringIndexOutOfBoundsException in
>> PortletServletRequestWrapper for some resource requests
>> * [WICKET-2806] - Javascript looking for related radio in group is
>> not working if css class is already assigned to radio
>> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
>>
>> ** Improvement
>> * [WICKET-2771] - Please support "isPrimary" for @SpringBean
>> * [WICKET-2776] - Enhancing RadioChoice input items with
>> individual title and css class attributes
>> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
>> * [WICKET-2796] - Improve error reporting on locked page maps
>> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
>> IModel<? extends Collection<T>>
>> * [WICKET-2813] - IndicatingAjaxButton should have construtors
>> that take a IModel for the button text as does AjaxButton.
>> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
>> extends Collection<T>>
>> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
>> * [WICKET-2830] - Make
>> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
>> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
>> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
>>
>> ** Wish
>> * [WICKET-2847] - Make StringResourceStream non final
>>
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Apache Wicket 1.4 increases type safety for web applications
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.7
Re: [vote] release wicket 1.4.8
Posted by Igor Vaynberg <ig...@gmail.com>.
the vote is now closed and has passed with two +1 votes. i will upload
the artifacts to the mirrors and get the ball rolling on the rest.
cheers
-igor
On Mon, Apr 26, 2010 at 10:12 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> this vote is to release wicket 1.4.8
>
> this maintenance release brings over 20 bug fixes and improvements.
>
> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
>
> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/
>
> changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
> (and below)
>
> vote ends Thursday 11am gmt-8
>
> cheers
>
> -igor
>
>
> Release Notes - Wicket - Version 1.4.8
>
>
> ** Bug
> * [WICKET-2075] - Pagemap is locked forever with some Page
> serialization exceptions
> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
> (e.g. for Page markup inheritance) together with IResourceStreams that
> do NOT also implement IFixedLocationResourceStream
> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
> digits are used (yyyy), e.g. 2010 --> 0010
> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
> * [WICKET-2779] - Submit a nested form via ajax to upload a file
> inside modal window does not work on IE.
> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
> returns false for non-existing keys, instead of the defaultValue
> * [WICKET-2799] - @RequireHttps not switching to https when
> setting response page to non-bookmarkable page
> * [WICKET-2802] - StringIndexOutOfBoundsException in
> PortletServletRequestWrapper for some resource requests
> * [WICKET-2806] - Javascript looking for related radio in group is
> not working if css class is already assigned to radio
> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
>
> ** Improvement
> * [WICKET-2771] - Please support "isPrimary" for @SpringBean
> * [WICKET-2776] - Enhancing RadioChoice input items with
> individual title and css class attributes
> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
> * [WICKET-2796] - Improve error reporting on locked page maps
> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
> IModel<? extends Collection<T>>
> * [WICKET-2813] - IndicatingAjaxButton should have construtors
> that take a IModel for the button text as does AjaxButton.
> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
> extends Collection<T>>
> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
> * [WICKET-2830] - Make
> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
>
> ** Wish
> * [WICKET-2847] - Make StringResourceStream non final
>
Re: [vote] release wicket 1.4.8
Posted by James Carman <jc...@carmanconsulting.com>.
Well, I tried your suggestion. Unfortunately, that breaks my existing
code still. My tables have header cells that span the entire length
of the table (they're vertical "bars"), but since it's split up into
thead/tbody/tfoot now, those rowspans don't work properly. Any
suggestions?
On Mon, Apr 26, 2010 at 3:40 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> not sure we can fix this, the markup in datatable changed in 1.4.6
> because it had other bugs in it. you will have to recopy the markup.
>
> -igor
>
> On Mon, Apr 26, 2010 at 11:06 AM, James Carman
> <jc...@carmanconsulting.com> wrote:
>> I believe I've found a regression. I have a custom subclass of
>> DataTable and here's its markup (I basically add my own toolbars):
>>
>> <wicket:panel>
>>
>> <span wicket:id="topToolbars">
>> <span wicket:id="toolbar"></span>
>> </span>
>>
>>
>> <tr wicket:id="rows">
>> <td wicket:id="cells">
>> <span wicket:id="cell">[cell]</span>
>> </td>
>> </tr>
>>
>> <span wicket:id="bottomToolbars">
>> <span wicket:id="toolbar"></span>
>> </span>
>>
>> </wicket:panel>
>>
>> I believe I borrowed that from the original markup file for DataTable.
>> Anyway, this works in 1.4.5 and when I upgrade to 1.4.6, I get the
>> following error. I've tried going back and forth and the version that
>> causes the regression is 1.4.6.
>>
>> 04-26@13:57:02 ERROR (RequestCycle) - close tag not found for tag:
>> <span wicket:id="topToolbars"
>> wicketpath="form_idPaths_table_topToolbars_1_toolbar">. Component:
>> [MarkupContainer [Component id = toolbar]]
>>
>> I would assume it's related to WICKET-2620, but I don't know.
>> Shouldn't we fix this before we do another release?
>>
>> On Mon, Apr 26, 2010 at 1:12 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>>> this vote is to release wicket 1.4.8
>>>
>>> this maintenance release brings over 20 bug fixes and improvements.
>>>
>>> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
>>>
>>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/
>>>
>>> changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
>>> (and below)
>>>
>>> vote ends Thursday 11am gmt-8
>>>
>>> cheers
>>>
>>> -igor
>>>
>>>
>>> Release Notes - Wicket - Version 1.4.8
>>>
>>>
>>> ** Bug
>>> * [WICKET-2075] - Pagemap is locked forever with some Page
>>> serialization exceptions
>>> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
>>> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
>>> (e.g. for Page markup inheritance) together with IResourceStreams that
>>> do NOT also implement IFixedLocationResourceStream
>>> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
>>> digits are used (yyyy), e.g. 2010 --> 0010
>>> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
>>> * [WICKET-2779] - Submit a nested form via ajax to upload a file
>>> inside modal window does not work on IE.
>>> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
>>> returns false for non-existing keys, instead of the defaultValue
>>> * [WICKET-2799] - @RequireHttps not switching to https when
>>> setting response page to non-bookmarkable page
>>> * [WICKET-2802] - StringIndexOutOfBoundsException in
>>> PortletServletRequestWrapper for some resource requests
>>> * [WICKET-2806] - Javascript looking for related radio in group is
>>> not working if css class is already assigned to radio
>>> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
>>>
>>> ** Improvement
>>> * [WICKET-2771] - Please support "isPrimary" for @SpringBean
>>> * [WICKET-2776] - Enhancing RadioChoice input items with
>>> individual title and css class attributes
>>> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
>>> * [WICKET-2796] - Improve error reporting on locked page maps
>>> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
>>> IModel<? extends Collection<T>>
>>> * [WICKET-2813] - IndicatingAjaxButton should have construtors
>>> that take a IModel for the button text as does AjaxButton.
>>> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
>>> extends Collection<T>>
>>> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
>>> * [WICKET-2830] - Make
>>> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
>>> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
>>> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
>>>
>>> ** Wish
>>> * [WICKET-2847] - Make StringResourceStream non final
>>>
>>
>
Re: [vote] release wicket 1.4.8
Posted by Igor Vaynberg <ig...@gmail.com>.
not sure we can fix this, the markup in datatable changed in 1.4.6
because it had other bugs in it. you will have to recopy the markup.
-igor
On Mon, Apr 26, 2010 at 11:06 AM, James Carman
<jc...@carmanconsulting.com> wrote:
> I believe I've found a regression. I have a custom subclass of
> DataTable and here's its markup (I basically add my own toolbars):
>
> <wicket:panel>
>
> <span wicket:id="topToolbars">
> <span wicket:id="toolbar"></span>
> </span>
>
>
> <tr wicket:id="rows">
> <td wicket:id="cells">
> <span wicket:id="cell">[cell]</span>
> </td>
> </tr>
>
> <span wicket:id="bottomToolbars">
> <span wicket:id="toolbar"></span>
> </span>
>
> </wicket:panel>
>
> I believe I borrowed that from the original markup file for DataTable.
> Anyway, this works in 1.4.5 and when I upgrade to 1.4.6, I get the
> following error. I've tried going back and forth and the version that
> causes the regression is 1.4.6.
>
> 04-26@13:57:02 ERROR (RequestCycle) - close tag not found for tag:
> <span wicket:id="topToolbars"
> wicketpath="form_idPaths_table_topToolbars_1_toolbar">. Component:
> [MarkupContainer [Component id = toolbar]]
>
> I would assume it's related to WICKET-2620, but I don't know.
> Shouldn't we fix this before we do another release?
>
> On Mon, Apr 26, 2010 at 1:12 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>> this vote is to release wicket 1.4.8
>>
>> this maintenance release brings over 20 bug fixes and improvements.
>>
>> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
>>
>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/
>>
>> changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
>> (and below)
>>
>> vote ends Thursday 11am gmt-8
>>
>> cheers
>>
>> -igor
>>
>>
>> Release Notes - Wicket - Version 1.4.8
>>
>>
>> ** Bug
>> * [WICKET-2075] - Pagemap is locked forever with some Page
>> serialization exceptions
>> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
>> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
>> (e.g. for Page markup inheritance) together with IResourceStreams that
>> do NOT also implement IFixedLocationResourceStream
>> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
>> digits are used (yyyy), e.g. 2010 --> 0010
>> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
>> * [WICKET-2779] - Submit a nested form via ajax to upload a file
>> inside modal window does not work on IE.
>> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
>> returns false for non-existing keys, instead of the defaultValue
>> * [WICKET-2799] - @RequireHttps not switching to https when
>> setting response page to non-bookmarkable page
>> * [WICKET-2802] - StringIndexOutOfBoundsException in
>> PortletServletRequestWrapper for some resource requests
>> * [WICKET-2806] - Javascript looking for related radio in group is
>> not working if css class is already assigned to radio
>> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
>>
>> ** Improvement
>> * [WICKET-2771] - Please support "isPrimary" for @SpringBean
>> * [WICKET-2776] - Enhancing RadioChoice input items with
>> individual title and css class attributes
>> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
>> * [WICKET-2796] - Improve error reporting on locked page maps
>> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
>> IModel<? extends Collection<T>>
>> * [WICKET-2813] - IndicatingAjaxButton should have construtors
>> that take a IModel for the button text as does AjaxButton.
>> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
>> extends Collection<T>>
>> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
>> * [WICKET-2830] - Make
>> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
>> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
>> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
>>
>> ** Wish
>> * [WICKET-2847] - Make StringResourceStream non final
>>
>
Re: [vote] release wicket 1.4.8
Posted by James Carman <jc...@carmanconsulting.com>.
I believe I've found a regression. I have a custom subclass of
DataTable and here's its markup (I basically add my own toolbars):
<wicket:panel>
<span wicket:id="topToolbars">
<span wicket:id="toolbar"></span>
</span>
<tr wicket:id="rows">
<td wicket:id="cells">
<span wicket:id="cell">[cell]</span>
</td>
</tr>
<span wicket:id="bottomToolbars">
<span wicket:id="toolbar"></span>
</span>
</wicket:panel>
I believe I borrowed that from the original markup file for DataTable.
Anyway, this works in 1.4.5 and when I upgrade to 1.4.6, I get the
following error. I've tried going back and forth and the version that
causes the regression is 1.4.6.
04-26@13:57:02 ERROR (RequestCycle) - close tag not found for tag:
<span wicket:id="topToolbars"
wicketpath="form_idPaths_table_topToolbars_1_toolbar">. Component:
[MarkupContainer [Component id = toolbar]]
I would assume it's related to WICKET-2620, but I don't know.
Shouldn't we fix this before we do another release?
On Mon, Apr 26, 2010 at 1:12 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> this vote is to release wicket 1.4.8
>
> this maintenance release brings over 20 bug fixes and improvements.
>
> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/
>
> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/
>
> changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811
> (and below)
>
> vote ends Thursday 11am gmt-8
>
> cheers
>
> -igor
>
>
> Release Notes - Wicket - Version 1.4.8
>
>
> ** Bug
> * [WICKET-2075] - Pagemap is locked forever with some Page
> serialization exceptions
> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together
> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup
> (e.g. for Page markup inheritance) together with IResourceStreams that
> do NOT also implement IFixedLocationResourceStream
> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4
> digits are used (yyyy), e.g. 2010 --> 0010
> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice
> * [WICKET-2779] - Submit a nested form via ajax to upload a file
> inside modal window does not work on IE.
> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always
> returns false for non-existing keys, instead of the defaultValue
> * [WICKET-2799] - @RequireHttps not switching to https when
> setting response page to non-bookmarkable page
> * [WICKET-2802] - StringIndexOutOfBoundsException in
> PortletServletRequestWrapper for some resource requests
> * [WICKET-2806] - Javascript looking for related radio in group is
> not working if css class is already assigned to radio
> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory
>
> ** Improvement
> * [WICKET-2771] - Please support "isPrimary" for @SpringBean
> * [WICKET-2776] - Enhancing RadioChoice input items with
> individual title and css class attributes
> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter
> * [WICKET-2796] - Improve error reporting on locked page maps
> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept
> IModel<? extends Collection<T>>
> * [WICKET-2813] - IndicatingAjaxButton should have construtors
> that take a IModel for the button text as does AjaxButton.
> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<?
> extends Collection<T>>
> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes
> * [WICKET-2830] - Make
> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final
> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final
> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc
>
> ** Wish
> * [WICKET-2847] - Make StringResourceStream non final
>