You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/11/01 18:40:08 UTC
[GitHub] [echarts] nhhaidee opened a new issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
nhhaidee opened a new issue #15989:
URL: https://github.com/apache/echarts/issues/15989
### Version
5.2.2
### Reproduction link
[https://codesandbox.io/s/brave-silence-4jwte](https://codesandbox.io/s/brave-silence-4jwte)
### Steps to reproduce
1. Plot custom chart using `renderItem` function
2. Set `labelLayout: { hideOverlap: true}`
### What is expected?
The label of components in custom chart must be display correctly in which hide labels will be display when zoom in
### What is actually happening?
Some labels are disappear when zoom in and zoom out again
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] nhhaidee commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
nhhaidee commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-1015811771
@pissang Our tool is waiting for the fixes for this bug and I am trying to fix this bug by myself. I've just started looking at Echarts code and am having difficulties figuring out which part of the code I should be working on, can you just give me some hints about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-956489613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] nhhaidee commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
nhhaidee commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-956496588
The chart before zoom in
The chart after zoom/in and out, some labels such M, N, orf1ab are disappeared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] nhhaidee edited a comment on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
nhhaidee edited a comment on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-956496588
The chart before zoom in
The chart after zoom/in and out, some labels such as M, N, orf1ab are disappeared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-957027089
This issue is labeled with `priority: high`, which means it's a frequently asked problem and we will fix it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-1019659389
@nhhaidee Hi, [LabelManager#layout](https://github.com/apache/echarts/blob/master/src/label/LabelManager.ts#L439) may be a good entry to dig into this issue. You can add a breakpoint in this function to see how it behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] nhhaidee commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
nhhaidee commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-956496588
The chart before zoom in
The chart after zoom/in and out, some labels such M, N, orf1ab are disappeared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] nhhaidee edited a comment on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
nhhaidee edited a comment on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-956496588
The chart before zoom in
The chart after zoom/in and out, some labels such as M, N, orf1ab are disappeared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-957027089
This issue is labeled with `priority: high`, which means it's a frequently asked problem and we will fix it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] nhhaidee edited a comment on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
nhhaidee edited a comment on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-956496588
The chart before zoom in
The chart after zoom/in and out, some labels such as M, N, orf1ab are disappeared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-956489613
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so.
*A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster.
You may also check out the [API](https://echarts.apache.org/api.html) and [chart option](https://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
If you are interested in the project, you may also subscribe to our [mailing list](https://echarts.apache.org/maillist.html).
Have a nice day! 🍵
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] nhhaidee commented on issue #15989: [Custom Chart] hideOverlap of labelLayout does not work correctly
Posted by GitBox <gi...@apache.org>.
nhhaidee commented on issue #15989:
URL: https://github.com/apache/echarts/issues/15989#issuecomment-1022538672
@pissang Thank for suggestion. I dug into the code and as my understanding, it seems that once a label is set to `ignore` (due to overlap) and it will be kept forever for that label. The code should be able to re-update `ignore` values whenever user zooms in or out
Please see the test file which I created and placed it into `test` folder for debugging this bug.
[custom-Gene.zip](https://github.com/apache/echarts/files/7944725/custom-Gene.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org