You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2025/11/20 03:45:49 UTC
[PR] Common pattern validation for all regexp* functions (druid)
abhishekrb19 opened a new pull request, #18762:
URL: https://github.com/apache/druid/pull/18762
Currently, if a user runs `regexp_like(c2, '[abc-d-12]')`, they receive a cryptic error message like "Illegal character range near index ..." and this is unclear when the sql is quite complex.
Move the `RegexpExtractExprMacro.compilePattern()` utility into a shared location and have all Regexp* macros use it, so that invalid regex patterns produce nicer error messages for users.
#### Release note
Nicer user-facing error messages for invalid patterns used in the regexp* functions.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] a release note entry in the PR description.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Common pattern validation for all regexp* functions (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 merged PR #18762:
URL: https://github.com/apache/druid/pull/18762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Common pattern validation for all regexp* functions (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on code in PR #18762:
URL: https://github.com/apache/druid/pull/18762#discussion_r2547354667
##########
processing/src/main/java/org/apache/druid/query/expression/RegexpReplaceExprMacro.java:
##########
@@ -96,7 +96,7 @@ private RegexpReplaceExpr(List<Expr> args)
final String patternString = (String) patternExpr.getLiteralValue();
this.arg = args.get(0);
- this.pattern = patternString != null ? Pattern.compile(patternString) : null;
Review Comment:
Yeah, this is okay because the original null semantics is retained at this call site.
`RegexpExprUtils.compilePattern()` is called only when `patternString` is not null, otherwise `pattern` continues to remain null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Common pattern validation for all regexp* functions (druid)
Posted by "jtuglu1 (via GitHub)" <gi...@apache.org>.
jtuglu1 commented on code in PR #18762:
URL: https://github.com/apache/druid/pull/18762#discussion_r2547010136
##########
processing/src/main/java/org/apache/druid/query/expression/RegexpReplaceExprMacro.java:
##########
@@ -96,7 +96,7 @@ private RegexpReplaceExpr(List<Expr> args)
final String patternString = (String) patternExpr.getLiteralValue();
this.arg = args.get(0);
- this.pattern = patternString != null ? Pattern.compile(patternString) : null;
Review Comment:
We are moving from `Pattern.compile(patternString)` to `Pattern.compile(StringUtils.nullToEmptyNonDruidDataString(patternString))`. Is this ok?
##########
processing/src/main/java/org/apache/druid/query/expression/RegexpExprUtils.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.query.expression;
+
+import org.apache.druid.error.InvalidInput;
+import org.apache.druid.java.util.common.StringUtils;
+
+import javax.annotation.Nullable;
+import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
+
+public class RegexpExprUtils
+{
+ /**
+ * Compile the provided pattern, or provide a nice error message if it cannot be compiled.
+ */
+ public static Pattern compilePattern(@Nullable String pattern, String functionName)
+ {
+ try {
+ return Pattern.compile(StringUtils.nullToEmptyNonDruidDataString(pattern));
+ }
+ catch (PatternSyntaxException e) {
+ throw InvalidInput.exception(
+ e,
+ StringUtils.format(
+ "An invalid pattern [%s] was provided for the %s function, error: [%s]",
Review Comment:
maybe box the function name as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Common pattern validation for all regexp* functions (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on code in PR #18762:
URL: https://github.com/apache/druid/pull/18762#discussion_r2547354667
##########
processing/src/main/java/org/apache/druid/query/expression/RegexpReplaceExprMacro.java:
##########
@@ -96,7 +96,7 @@ private RegexpReplaceExpr(List<Expr> args)
final String patternString = (String) patternExpr.getLiteralValue();
this.arg = args.get(0);
- this.pattern = patternString != null ? Pattern.compile(patternString) : null;
Review Comment:
Yeah, this is okay because the original null semantics is retained at this call site.
`RegexpExprUtils.compilePattern()` is called only when `patternString` is null, otherwise `pattern` continues to remain null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org