[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI

["Nihal Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502306#comment-16502306 ] 

Nihal Jain commented on HBASE-20577:
------------------------------------

Hi [~yuzhihong@gmail.com], while trying out rest server, I discovered that Rest does not have 'header.jsp'. So this throws a FNF exception in loglevel page. My bad, i was not aware of other projects having web UI when I wrote this fix. Sorry for the trouble.
 Anyways, I think it would be wrong to assume all projects' web ui's will be having 'header.jsp'. To mitigate, we can do the following:
 * 1) fall back to original log level design if 'header.jsp' is not present
 * 2) Next, we can refactor jsp file of other projects (like rest) to have 'header.jsp' and 'footer.jsp'

How should we handle it? Should I create a new JIRA for point 1 and 2 together? Or can we just re-open this issue and add point 1 fix as addendum? And refactor related code in another jira?

> Make Log Level page design consistent with the design of other pages in UI
> --------------------------------------------------------------------------
>
>                 Key: HBASE-20577
>                 URL: https://issues.apache.org/jira/browse/HBASE-20577
>             Project: HBase
>          Issue Type: Improvement
>          Components: UI, Usability
>            Reporter: Nihal Jain
>            Assignee: Nihal Jain
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HBASE-20577.master.001.patch, HBASE-20577.master.002.patch, after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png, before_patch_no_validation_required_field.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not be allowed to click submit button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)