You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/01/14 20:08:46 UTC
Review Request 29888: Views: Velocity log file - Run ambari-server
using non-root causes issues with view instances
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29888/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-9130
https://issues.apache.org/jira/browse/AMBARI-9130
Repository: ambari
Description
-------
Setup ambari-server to run with non-root daemon (ambari-server setup, select a non-root daemon account) and views fail with a velocity error
The user can not access the default location for the Velocity log file.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 51f3a51
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 8b7a641
Diff: https://reviews.apache.org/r/29888/diff/
Testing
-------
Manual testing of view using Velocity template. Added unit test to verify velocity logger setting. All existing tests pass.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29:09 min
[INFO] Finished at: 2015-01-14T13:54:12-05:00
[INFO] Final Memory: 42M/501M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 29888: Views: Velocity log file - Run
ambari-server using non-root causes issues with view instances
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29888/#review68089
-----------------------------------------------------------
Ship it!
Just my one comment about configuring what gets put into Ambari's log; we don't want Velocity putting too much garbage in there and making it hard to read.
- Jonathan Hurley
On Jan. 14, 2015, 2:08 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29888/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 2:08 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-9130
> https://issues.apache.org/jira/browse/AMBARI-9130
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Setup ambari-server to run with non-root daemon (ambari-server setup, select a non-root daemon account) and views fail with a velocity error
>
> The user can not access the default location for the Velocity log file.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 51f3a51
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 8b7a641
>
> Diff: https://reviews.apache.org/r/29888/diff/
>
>
> Testing
> -------
>
> Manual testing of view using Velocity template. Added unit test to verify velocity logger setting. All existing tests pass.
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 29:09 min
> [INFO] Finished at: 2015-01-14T13:54:12-05:00
> [INFO] Final Memory: 42M/501M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 29888: Views: Velocity log file - Run
ambari-server using non-root causes issues with view instances
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On Jan. 14, 2015, 7:32 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, line 135
> > <https://reviews.apache.org/r/29888/diff/1/?file=821511#file821511line135>
> >
> > How much velocity stuff gets logged to log4j? Is there any need to configure Ambari's log4j.properties to restrict what actually gets logged by Velocity via:
> >
> > `log4j.org.apache.velocity=WARN`
> >
> > Or something similar?
Good question. I've never actually seen anything in the Velocity log so I'm guessing it won't be an issue. I don't think that normal usage (at least from views) generates any log messages at all. I had to force a dummy log message just to test it.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29888/#review68087
-----------------------------------------------------------
On Jan. 14, 2015, 7:08 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29888/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 7:08 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-9130
> https://issues.apache.org/jira/browse/AMBARI-9130
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Setup ambari-server to run with non-root daemon (ambari-server setup, select a non-root daemon account) and views fail with a velocity error
>
> The user can not access the default location for the Velocity log file.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 51f3a51
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 8b7a641
>
> Diff: https://reviews.apache.org/r/29888/diff/
>
>
> Testing
> -------
>
> Manual testing of view using Velocity template. Added unit test to verify velocity logger setting. All existing tests pass.
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 29:09 min
> [INFO] Finished at: 2015-01-14T13:54:12-05:00
> [INFO] Final Memory: 42M/501M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 29888: Views: Velocity log file - Run
ambari-server using non-root causes issues with view instances
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29888/#review68087
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
<https://reviews.apache.org/r/29888/#comment112245>
How much velocity stuff gets logged to log4j? Is there any need to configure Ambari's log4j.properties to restrict what actually gets logged by Velocity via:
`log4j.org.apache.velocity=WARN`
Or something similar?
- Jonathan Hurley
On Jan. 14, 2015, 2:08 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29888/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 2:08 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-9130
> https://issues.apache.org/jira/browse/AMBARI-9130
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Setup ambari-server to run with non-root daemon (ambari-server setup, select a non-root daemon account) and views fail with a velocity error
>
> The user can not access the default location for the Velocity log file.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 51f3a51
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 8b7a641
>
> Diff: https://reviews.apache.org/r/29888/diff/
>
>
> Testing
> -------
>
> Manual testing of view using Velocity template. Added unit test to verify velocity logger setting. All existing tests pass.
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 29:09 min
> [INFO] Finished at: 2015-01-14T13:54:12-05:00
> [INFO] Final Memory: 42M/501M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>