You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/11/23 18:05:48 UTC
[GitHub] jmeter pull request #339: Refactored TestChangeCase.
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/339
Refactored TestChangeCase.
Improved readability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter casechange-test-improvment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/339.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #339
----
commit 019b3d5eb20c0a930d0d80a0bc66d84566c1f9f0
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-21T11:38:53Z
Refactored TestChangeCase.
----
---
[GitHub] jmeter pull request #339: Refactored TestChangeCase
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/339
---
[GitHub] jmeter issue #339: Refactored TestChangeCase.
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/339
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=h1) Report
> Merging [#339](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/85a9f133e4cca309b3b8f4c3a0e49a5a47f7e93e?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `89.28%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/339/graphs/tree.svg?token=6Q7CI1wFSh&height=150&src=pr&width=650)](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #339 +/- ##
===========================================
- Coverage 57.9% 57.89% -0.01%
- Complexity 10023 10024 +1
===========================================
Files 1148 1148
Lines 73798 73773 -25
Branches 7331 7331
===========================================
- Hits 42732 42713 -19
+ Misses 28587 28580 -7
- Partials 2479 2480 +1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rc/org/apache/jmeter/functions/TestChangeCase.java](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1Rlc3RDaGFuZ2VDYXNlLmphdmE=) | `94% <89.28%> (-2%)` | `13 <11> (+1)` | |
| [...apache/jmeter/extractor/TestBoundaryExtractor.java](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL1Rlc3RCb3VuZGFyeUV4dHJhY3Rvci5qYXZh) | `97.88% <0%> (ø)` | `17% <0%> (ø)` | :arrow_down: |
| [...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==) | `61.29% <0%> (+6.45%)` | `15% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=footer). Last update [85a9f13...019b3d5](https://codecov.io/gh/apache/jmeter/pull/339?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---