You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/31 04:57:44 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

HyukjinKwon opened a new pull request #32011:
URL: https://github.com/apache/spark/pull/32011


   ### What changes were proposed in this pull request?
   
   This PR proposes to cache Maven, SBT and Scala in all jobs that use them. For simplicity, we use the same key `build-` and just cache all SBT, Maven and Scala. The cache is not very large.
   
   ### Why are the changes needed?
   
   To speed up the build.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   It will be tested in this PR's GA jobs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang closed pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #32011:
URL: https://github.com/apache/spark/pull/32011


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810761149


   cc @dongjoon-hyun, @gengliangwang and @maropu FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang commented on a change in pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32011:
URL: https://github.com/apache/spark/pull/32011#discussion_r604731377



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -367,6 +367,17 @@ jobs:
     steps:
     - name: Checkout Spark repository
       uses: actions/checkout@v2
+    - name: Cache Scala, SBT and Maven

Review comment:
       Nit: is there any way to avoid duplicated specs for this step "Cache Scala, SBT and Maven"

##########
File path: .github/workflows/build_and_test.yml
##########
@@ -367,6 +367,17 @@ jobs:
     steps:
     - name: Checkout Spark repository
       uses: actions/checkout@v2
+    - name: Cache Scala, SBT and Maven

Review comment:
       Nit: is there any way to avoid duplicated specs for this step "Cache Scala, SBT and Maven"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810889593


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136748/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810814224






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32011:
URL: https://github.com/apache/spark/pull/32011#discussion_r604732228



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -367,6 +367,17 @@ jobs:
     steps:
     - name: Checkout Spark repository
       uses: actions/checkout@v2
+    - name: Cache Scala, SBT and Maven

Review comment:
       I tired to find a way so hard but couldn't find so far.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810761488


   **[Test build #136748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136748/testReport)** for PR 32011 at commit [`642d7c0`](https://github.com/apache/spark/commit/642d7c09f604c2912042e1b863a6750d86184170).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #32011:
URL: https://github.com/apache/spark/pull/32011#discussion_r604739239



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -367,6 +367,17 @@ jobs:
     steps:
     - name: Checkout Spark repository
       uses: actions/checkout@v2
+    - name: Cache Scala, SBT and Maven

Review comment:
       It seems there are many requests for that, but GA still does not support it: https://github.community/t/support-for-yaml-anchors/16128




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810814444


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41330/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810873918


   **[Test build #136748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136748/testReport)** for PR 32011 at commit [`642d7c0`](https://github.com/apache/spark/commit/642d7c09f604c2912042e1b863a6750d86184170).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang commented on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810949277


   Thanks, merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810761488


   **[Test build #136748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136748/testReport)** for PR 32011 at commit [`642d7c0`](https://github.com/apache/spark/commit/642d7c09f604c2912042e1b863a6750d86184170).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810889593


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136748/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810988735


   Thanks @gengliangwang! Although this is an improvement, I manually cherry-picked related changes to reduce conflicts (branch-3.1 and branch-3.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang commented on a change in pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32011:
URL: https://github.com/apache/spark/pull/32011#discussion_r604739085



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -367,6 +367,17 @@ jobs:
     steps:
     - name: Checkout Spark repository
       uses: actions/checkout@v2
+    - name: Cache Scala, SBT and Maven

Review comment:
       OK that's fine :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32011: [SPARK-34915][INFRA] Cache Maven, SBT and Scala in all jobs that use them

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32011:
URL: https://github.com/apache/spark/pull/32011#issuecomment-810814444


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41330/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org