You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/01 03:29:23 UTC

[GitHub] [inlong] lucaspeng12138 opened a new pull request, #4828: [INLONG-4827] Add flink config into yaml

lucaspeng12138 opened a new pull request, #4828:
URL: https://github.com/apache/inlong/pull/4828

   ### Prepare a Pull Request
   [Improve][Kubernets] Add flink configure in k8s yaml
   
   - Fixes #4827 
   
   ### Motivation
   
   Add flink configure in k8s yaml.
   Get env from yaml to change inlong-manager/plugins/flink-sort-plugin.properties flink hostname and port.
   
   
   ### Modifications
   
   Add flink configure in k8s yaml.
   Get env from yaml to change inlong-manager/plugins/flink-sort-plugin.properties flink hostname and port.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on a diff in pull request #4828: [INLONG-4827][Kubernets] Add Flink config into the YAML files

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #4828:
URL: https://github.com/apache/inlong/pull/4828#discussion_r911643134


##########
docker/kubernetes/values.yaml:
##########
@@ -645,3 +645,7 @@ external:
     enabled: false
     serviceUrl: "localhost:6650"
     adminUrl: "localhost:8080"
+  flink:
+    enabled: false

Review Comment:
   Flink is necessary, it's better to remove this option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #4828: [INLONG-4827][Kubernets] Add Flink config into the YAML files

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4828:
URL: https://github.com/apache/inlong/pull/4828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org