You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/26 15:51:00 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3993: Fix raw
templates not being downloaded
Spaceman1984 opened a new pull request #3993: Fix raw templates not being downloaded
URL: https://github.com/apache/cloudstack/pull/3993
## Description
<!--- Describe your changes in detail -->
This PR fixes an error where raw template files are not being downloaded
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Fixes: #2820
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This was tested by adding a raw template to be downloaded from the UI
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3993: Fixes raw
templates not downloading
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3993: Fixes raw templates not downloading
URL: https://github.com/apache/cloudstack/pull/3993#issuecomment-605209085
2 x approvals, automated regression tests fine, manual (fix) tests fine.
Merging based on ^^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3993: Fix raw
templates not being downloaded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3993: Fix raw templates not being downloaded
URL: https://github.com/apache/cloudstack/pull/3993#issuecomment-604510280
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb merged pull request #3993: Fixes raw
templates not downloading
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #3993: Fixes raw templates not downloading
URL: https://github.com/apache/cloudstack/pull/3993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3993: Fixes raw
templates not downloading
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3993: Fixes raw templates not downloading
URL: https://github.com/apache/cloudstack/pull/3993#issuecomment-604951049
LGTM
Tested with http://download.cloudstack.org/testing/CentOS-7-x86_64-GenericCloud-1511.raw.bz2 (temp abuse of the hosting, due to lack of availability of raw.bz2 images online on plain HTTP)
Works fine, downloaded, unpacked, and eventually Ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3993: Fixes raw
templates not downloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3993: Fixes raw templates not downloading
URL: https://github.com/apache/cloudstack/pull/3993#issuecomment-604814926
<b>Trillian test result (tid-1326)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26195 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3993-t1326-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 167.82 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 167.85 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 224.70 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3993: Fixes raw
templates not downloading
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3993: Fixes raw templates not downloading
URL: https://github.com/apache/cloudstack/pull/3993#issuecomment-604691158
testing, very risk poor change (downloading/image store only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3993: Fix raw
templates not being downloaded
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3993: Fix raw templates not being downloaded
URL: https://github.com/apache/cloudstack/pull/3993#issuecomment-604521624
Packaging result: ✔centos7 ✔debian. JID-1096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3993: Fix raw
templates not being downloaded
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3993: Fix raw templates not being downloaded
URL: https://github.com/apache/cloudstack/pull/3993#issuecomment-604509938
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services