[GitHub] [superset] michael-s-molina edited a comment on pull request #19085: feat(select): keep options order when not in async mode

[GitBox <gi...@apache.org>]

michael-s-molina edited a comment on pull request #19085:
URL: https://github.com/apache/superset/pull/19085#issuecomment-1064237769


   > May do a bigger sweep in other components to clean up similar order props later.
   
   If you check the references to `sortComparator`, we have only 10 files. It would be a good idea to clean these as part of this PR to avoid confusion on master since this property won't be working for these selects. It's also important to validate sorting for these use cases, especially the `SelectFilterPlugin` where the order can be reversed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org