You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by lizhanhui <gi...@git.apache.org> on 2017/04/12 16:26:26 UTC
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/91
[ROCKETMQ-174]Fix spelling errors
This is to fix large number of spelling errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-174
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit b5604b65a269e3ba191eb0aed83b485839b5011f
Author: Zhanhui Li <li...@apache.org>
Date: 2017-04-12T16:24:31Z
Spelling fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11449818)
Coverage increased (+0.006%) to 37.921% when pulling **12b03d83beccdd5e68df28bad2ab62bea6f8b1a4 on lizhanhui:ROCKETMQ-174** into **80aac138d905561c7a63c8e15fdfe60e958a3032 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115475862
--- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -907,10 +907,10 @@ public void queryMessage(
final QueryMessageRequestHeader requestHeader,
final long timeoutMillis,
final InvokeCallback invokeCallback,
- final Boolean isUnqiueKey
+ final Boolean isUnqueKey
--- End diff --
is it isUniqueKey ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478015
--- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java ---
@@ -27,23 +27,23 @@
public class TopicRouteData extends RemotingSerializable {
private String orderTopicConf;
- private List<QueueData> queueDatas;
- private List<BrokerData> brokerDatas;
+ private List<QueueData> queueDataList;
+ private List<BrokerData> brokerDataList;
--- End diff --
It is modification of protocol, IMO, it's improper for upgrade of server or client.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
Guys, let's merge this fix after the conflicts are resolved.
I also don't like breaks in minor versions, but there are too many spelling mistakes and writing workarounds for each is hard. Let's do it while we are in incubating phase, and make an announcement in release notes.
Any other ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211660
--- Diff: client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionState.java ---
@@ -19,5 +19,5 @@
public enum LocalTransactionState {
COMMIT_MESSAGE,
ROLLBACK_MESSAGE,
- UNKNOW,
+ UNKNOWN,
--- End diff --
The same above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111319070
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
#### If the change is non-trivial please include some unit tests that cover the new functionality.
#### If you are introducing a completely new feature or API it is a good idea to start a wiki and get consensus on the basic design first.
-#### It is our job to follow up on patches in a timely fashion. Nag us if we aren't doing our job (sometimes we drop things).
+#### It is our job to follow up on patches in a timely fashion. Nag us if we arn't doing our job timely enough (sometimes we may miss things).
--- End diff --
Yes, aren't is right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111317677
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
#### If the change is non-trivial please include some unit tests that cover the new functionality.
#### If you are introducing a completely new feature or API it is a good idea to start a wiki and get consensus on the basic design first.
-#### It is our job to follow up on patches in a timely fashion. Nag us if we aren't doing our job (sometimes we drop things).
+#### It is our job to follow up on patches in a timely fashion. Nag us if we arn't doing our job timely enough (sometimes we may miss things).
--- End diff --
arn't -> aren't ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11057354)
Coverage increased (+0.03%) to 34.653% when pulling **b5604b65a269e3ba191eb0aed83b485839b5011f on lizhanhui:ROCKETMQ-174** into **7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11083278)
Coverage increased (+0.0007%) to 34.626% when pulling **7e07b87f7124d21c69c5d61169a2c466714239eb on lizhanhui:ROCKETMQ-174** into **7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111708191
--- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeResponseHeader.java ---
@@ -16,15 +16,15 @@
*/
/**
- * $Id: GetEarliestMsgStoretimeResponseHeader.java 1835 2013-05-16 02:00:50Z vintagewang@apache.org $
+ * $Id: GetEarliestMsgStoreTimeResponseHeader.java 1835 2013-05-16 02:00:50Z vintagewang@apache.org $
--- End diff --
It should not be here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524663
--- Diff: client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java ---
@@ -18,6 +18,6 @@
import org.apache.rocketmq.common.message.Message;
-public interface LocalTransactionExecuter {
- public LocalTransactionState executeLocalTransactionBranch(final Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --
This is why I make these changes thorough PR process instead of regarding them trivial and merging directly.
We can discuss to figure out an acceptable way.
You may also notice that I do not change configuration name spelling issues yet and I am expecting opinions too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524324
--- Diff: client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java ---
@@ -18,6 +18,6 @@
import org.apache.rocketmq.common.message.Message;
-public interface LocalTransactionExecuter {
- public LocalTransactionState executeLocalTransactionBranch(final Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --
So in the next version, we must announce that they may face the compatible problem when they use XXXX in the older version.
Before they update, they must know about this and know how to fix them , and then upgrade.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111704125
--- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeRequestHeader.java ---
@@ -16,15 +16,15 @@
*/
/**
- * $Id: GetEarliestMsgStoretimeRequestHeader.java 1835 2013-05-16 02:00:50Z vintagewang@apache.org $
+ * $Id: GetEarliestMsgStoreTimeRequestHeader.java 1835 2013-05-16 02:00:50Z vintagewang@apache.org $
--- End diff --
Why do we need this line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
Overall looks good to me. Nice job!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478367
--- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/header/QueryMessageResponseHeader.java ---
@@ -28,7 +28,7 @@
@CFNotNull
private Long indexLastUpdateTimestamp;
@CFNotNull
- private Long indexLastUpdatePhyoffset;
+ private Long indexLastUpdatePhyOffset;
--- End diff --
Protocol modification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111709175
--- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeResponseHeader.java ---
@@ -16,15 +16,15 @@
*/
/**
- * $Id: GetEarliestMsgStoretimeResponseHeader.java 1835 2013-05-16 02:00:50Z vintagewang@apache.org $
+ * $Id: GetEarliestMsgStoreTimeResponseHeader.java 1835 2013-05-16 02:00:50Z vintagewang@apache.org $
--- End diff --
There are many files with such lines. If you don't mind, let's have them removed with this commit ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
@zhouxinyu @vesense
for some public class or enum, I don't agree we rename it directly since it will introduce the compatibility problem for the user who upgrade from the older versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
Agreed. Any other opinion for this PR? @lizhanhui please resolve the conflicts, we could merge this PR later~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115647528
--- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java ---
@@ -27,23 +27,23 @@
public class TopicRouteData extends RemotingSerializable {
private String orderTopicConf;
- private List<QueueData> queueDatas;
- private List<BrokerData> brokerDatas;
+ private List<QueueData> queueDataList;
+ private List<BrokerData> brokerDataList;
--- End diff --
Right. looks we have to keep it intact.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115645553
--- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -907,10 +907,10 @@ public void queryMessage(
final QueryMessageRequestHeader requestHeader,
final long timeoutMillis,
final InvokeCallback invokeCallback,
- final Boolean isUnqiueKey
+ final Boolean isUnqueKey
--- End diff --
Thanks for point it out, unique key.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11057354)
Coverage increased (+0.03%) to 34.653% when pulling **b5604b65a269e3ba191eb0aed83b485839b5011f on lizhanhui:ROCKETMQ-174** into **7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
The JIRA issue is here: https://issues.apache.org/jira/browse/ROCKETMQ-174
And I have added a time tracker for this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211195
--- Diff: client/src/main/java/org/apache/rocketmq/client/consumer/listener/ConsumeReturnType.java ---
@@ -33,7 +33,7 @@
/**
* consume return null
*/
- RETURNNULL,
+ RETURN_NULL,
--- End diff --
This is in an enum in client, we should be cautions for this since the user may has been using it.
Maybe we can comment in the java doc and explain that we will rename it in latter version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111525174
--- Diff: client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java ---
@@ -18,6 +18,6 @@
import org.apache.rocketmq.common.message.Message;
-public interface LocalTransactionExecuter {
- public LocalTransactionState executeLocalTransactionBranch(final Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --
For cinfiguration issue, we can fix them by pointing them to the same right spelling config.
private int rightConfig;
@Deprecated
public int getTypoConfig(){
return rightConfig;
}
@Deprecated
public void setTypoConfig(int val) {
this.rightConfig = val;
}
getter/setter for right config...
But since client config and server config is working in tatolly different ways that server config uses reflection to load configurations so this should be only work for client configuration typo issue.
I suggest we post another two typo issues for client configuration and server configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111522507
--- Diff: client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java ---
@@ -18,6 +18,6 @@
import org.apache.rocketmq.common.message.Message;
-public interface LocalTransactionExecuter {
- public LocalTransactionState executeLocalTransactionBranch(final Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --
1) This project is still at incubation stage, if we do not correct things now, we may never ever get the chance to fix them afterwards.
2) Transaction related feature is not currently implemented, IMO, we may fix this interface before it's widely used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111704133
--- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeResponseHeader.java ---
@@ -16,15 +16,15 @@
*/
/**
- * $Id: GetEarliestMsgStoretimeResponseHeader.java 1835 2013-05-16 02:00:50Z vintagewang@apache.org $
+ * $Id: GetEarliestMsgStoreTimeResponseHeader.java 1835 2013-05-16 02:00:50Z vintagewang@apache.org $
--- End diff --
Why do we need this line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211864
--- Diff: client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java ---
@@ -18,6 +18,6 @@
import org.apache.rocketmq.common.message.Message;
-public interface LocalTransactionExecuter {
- public LocalTransactionState executeLocalTransactionBranch(final Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --
We can't just rename a public interface, since the user who updates will find it not able to compile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
> please resolve the conflicts firstly, we have to be cautious about this PR.
Agree, this PR introduces too many trivial changes and I'd like abandon this PR and create several small changes, applying divide-and-conquer strategy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
@shroman @zhouxinyu Could you help review this PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---