You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2018/01/14 23:49:59 UTC
[jclouds/jclouds-site] Minor text changes and small corrections (take
2) (#208)
Version of #207 with the source branch now in the correct repo
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/208
-- Commit Summary --
* Blog post for Keystone V3
* Fix typo
* Completed blog post
* Minor text changes and small corrections
-- File Changes --
A _posts/2018-01-11-keystone-v3.md (84)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/208.patch
https://github.com/jclouds/jclouds-site/pull/208.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208
Re: [jclouds/jclouds-site] Minor text changes and small corrections
(take 2) (#208)
Posted by Andrew Phillips <no...@github.com>.
demobox commented on this pull request.
> * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have been refactored and generalised into:
* `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers.
* `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers.
+
+Use `AuthenticationModule` and `ServiceCatalogModule` when developing OpenStack APIs.
@nacx Updated in 1d801fc
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208#pullrequestreview-88937519
Re: [jclouds/jclouds-site] Minor text changes and small corrections
(take 2) (#208)
Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.
> * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have been refactored and generalised into:
* `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers.
* `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers.
+
+Replace uses of `KeystoneAuthenticationModule` with `AuthenticationModule`, and uses of `AuthenticationApiModule` with `ServiceCatalogModule`.
Yes, that's fine :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208#discussion_r161614337
Re: [jclouds/jclouds-site] Minor text changes and small corrections
(take 2) (#208)
Posted by jclouds-commentator <no...@github.com>.
Go to http://20a88d03f685268ec18a-d31bd6059e70aaad8f4bae867aaabffc.r36.cf5.rackcdn.com/ to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208#issuecomment-357553434
Re: [jclouds/jclouds-site] Minor text changes and small corrections
(take 2) (#208)
Posted by Andrew Phillips <no...@github.com>.
Preview here: http://20a88d03f685268ec18a-d31bd6059e70aaad8f4bae867aaabffc.r36.cf5.rackcdn.com/blog/2018/01/11/keystone-v3/
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208#issuecomment-357553968
Re: [jclouds/jclouds-site] Minor text changes and small corrections
(take 2) (#208)
Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.
> * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have been refactored and generalised into:
* `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers.
* `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers.
+
+Use `AuthenticationModule` and `ServiceCatalogModule` when developing OpenStack APIs.
Cool! I'm merging it into the `keystonev3` branch so we can publish it as soon as everything is merged. Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208#discussion_r161684636
Re: [jclouds/jclouds-site] Minor text changes and small corrections
(take 2) (#208)
Posted by Andrew Phillips <no...@github.com>.
demobox commented on this pull request.
> * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have been refactored and generalised into:
* `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers.
* `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers.
+
+Replace uses of `KeystoneAuthenticationModule` with `AuthenticationModule`, and uses of `AuthenticationApiModule` with `ServiceCatalogModule`.
> Those modules are already included by all OpenStack APIs, so that info is interesting only for those writing new APIs.
So is the guidance something like "Use `AuthenticationModule` and `ServiceCatalogModule` when developing OpenStack APIs."?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208#discussion_r161611424
Re: [jclouds/jclouds-site] Minor text changes and small corrections
(take 2) (#208)
Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.
> * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have been refactored and generalised into:
* `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers.
* `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers.
+
+Replace uses of `KeystoneAuthenticationModule` with `AuthenticationModule`, and uses of `AuthenticationApiModule` with `ServiceCatalogModule`.
This is not strictly true, and that's why I wrote it that way. The KeystoneAuthModule contained both, the authentication configuration and the service catalog one, and the AuthenticationApiModule just bound the internal Authentication API.
I've refactored it in a way that makes more sense, moving all config to the AuthenticationModule and the service catalog parsing to the Service Catalog module, but I don't think we need to mention that. Those modules are already included by all OpenStack APIs, so that info is interesting only for those writing new APIs. I wanted to mention the refactoring, but users won't need to replace anything when upgrading, so I'd just remove this last sentence.
Apart from this, LGTM. Many thanks for reviewing! :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208#pullrequestreview-88741843
Re: [jclouds/jclouds-site] Minor text changes and small corrections
(take 2) (#208)
Posted by jclouds-commentator <no...@github.com>.
Go to http://5d36d0aba8c170e9a4c5-ce263ec4815b2c3b731b4bdd285b4574.r24.cf5.rackcdn.com/ to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/208#issuecomment-357794183