You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2018/03/05 09:53:23 UTC

[GitHub] carbondata pull request #2031: [CARBONDATA-2223] Remove unused listeners

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/2031

    [CARBONDATA-2223] Remove unused listeners

    Remove unused listeners
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [x] Testing done
            Manual Testing
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata listeners

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2031
    
----
commit 9a8b245cf96564bdf1cb0ff297778db63b288103
Author: dhatchayani <dh...@...>
Date:   2018-03-05T09:47:13Z

    [CARBONDATA-2223] Remove unused listeners

----


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by KanakaKumar <gi...@git.apache.org>.

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    LGTM


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2977/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3857/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3138/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4222/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3196/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3866/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3197/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4372/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4097/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2966/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4196/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3028/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3773/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4429/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by dhatchayani <gi...@git.apache.org>.

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Retest this please


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4430/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4272/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3133/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by manishgupta88 <gi...@git.apache.org>.

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    LGTM


---

[GitHub] carbondata pull request #2031: [CARBONDATA-2223] Adding Listener Support for...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2031


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4217/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4209/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by dhatchayani <gi...@git.apache.org>.

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    retest this please


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2851/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4098/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3941/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3959/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4417/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by manishgupta88 <gi...@git.apache.org>.

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    LGTM


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2972/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4075/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3950/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2949/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3864/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3183/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3847/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3865/



---

[GitHub] carbondata pull request #2031: [CARBONDATA-2223] Adding Listener Support for...

Posted by manishgupta88 <gi...@git.apache.org>.

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2031#discussion_r175657383
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java ---
    @@ -151,10 +153,10 @@ private BlockMetaInfo createBlockMetaInfo(String carbonDataFile) throws IOExcept
           }
           if (missedIdentifiers.size() > 0) {
             SegmentIndexFileStore indexFileStore = new SegmentIndexFileStore();
    -
    +        List<String> filesRead = new ArrayList<>();
    --- End diff --
    
    use Set in place of List...Set will have a better performance as compared to list as your data grows


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3848/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3119/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2951/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4437/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2829/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3203/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by dhatchayani <gi...@git.apache.org>.

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    retest this please


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2854/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Adding Listener Support for Partit...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3951/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2853/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4353/



---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by dhatchayani <gi...@git.apache.org>.

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    retest this please


---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2031
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4194/



---