[GitHub] tswast commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'

[GitBox <gi...@apache.org>]

tswast commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r211622902
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -656,6 +671,10 @@ def run_query(self,
                 configuration['query'][
                     'schemaUpdateOptions'] = schema_update_options
 
+        if 'configuration' in api_resource_configs:
+            for key in api_resource_configs['configuration']:
+                configuration[key] = api_resource_configs['configuration'][key]
 
 Review comment:
   There are pretty few top-level keys: "query" and "labels" are the only two I can think of. Wouldn't specifying a `query` key in `api_resource_configs` overwrite all the options that were just applied?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services