[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5947: GEODE-8870: Removes GFE_5* and GFE_6*

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #5947:
URL: https://github.com/apache/geode/pull/5947#discussion_r564796154



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/persistence/DiskInitFileParser.java
##########
@@ -469,15 +465,15 @@ public DiskStoreID parse() throws IOException, ClassNotFoundException {
           readEndOfRecord(dis);
           if (logger.isTraceEnabled(LogMarker.PERSIST_RECOVERY_VERBOSE)) {
             logger.trace(LogMarker.PERSIST_RECOVERY_VERBOSE,
-                "IFREC_REVOKE_DISK_STORE_ID id={}" + pattern);
+                "IFREC_REVOKE_DISK_STORE_ID id={}", pattern);
           }
           interpreter.cmnRevokeDiskStoreId(pattern);
         }
           break;
         default:
           throw new DiskAccessException(
               String.format("Unknown opCode %s found in disk initialization file.", opCode),
-              this.interpreter.getNameForError());
+              interpreter.getNameForError());

Review comment:
       If it is redundant it is noise.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org