You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Mikhail Loenko (JIRA)" <ji...@apache.org> on 2006/01/30 11:47:33 UTC
[jira] Created: (HARMONY-55) remove PerformanceTest from hierarchy
of unit tests in security2
remove PerformanceTest from hierarchy of unit tests in security2
----------------------------------------------------------------
Key: HARMONY-55
URL: http://issues.apache.org/jira/browse/HARMONY-55
Project: Harmony
Type: Improvement
Reporter: Mikhail Loenko
As it was discussed in the mail threads PerfromanceTest class should be removed from hierarchy of unit tests in security2,
the tests should extend TestCase class.
The tests should be refactored to remove redundant logging that is currently done via PerformanceTest.
I'm going to provide a patch in a day or two
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-55) remove PerformanceTest from hierarchy
of unit tests in security2
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-55?page=all ]
Mikhail Loenko updated HARMONY-55:
----------------------------------
Attachment: patch.txt
Replaces 'extends PerformanceTest' with 'extends TestCase'
Removes redundant 'logln'
Some tests refactored to return test result in the status rather than in the log file
> remove PerformanceTest from hierarchy of unit tests in security2
> ----------------------------------------------------------------
>
> Key: HARMONY-55
> URL: http://issues.apache.org/jira/browse/HARMONY-55
> Project: Harmony
> Type: Improvement
> Reporter: Mikhail Loenko
> Attachments: patch.txt
>
> As it was discussed in the mail threads PerfromanceTest class should be removed from hierarchy of unit tests in security2,
> the tests should extend TestCase class.
> The tests should be refactored to remove redundant logging that is currently done via PerformanceTest.
> I'm going to provide a patch in a day or two
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-55) remove PerformanceTest from hierarchy
of unit tests in security2
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-55?page=all ]
Tim Ellison resolved HARMONY-55:
--------------------------------
Resolution: Fixed
Mikhail,
Patch applied to SECURITY2 module at repo revision 373789.
Please check that it fully resolves this issue.
> remove PerformanceTest from hierarchy of unit tests in security2
> ----------------------------------------------------------------
>
> Key: HARMONY-55
> URL: http://issues.apache.org/jira/browse/HARMONY-55
> Project: Harmony
> Type: Improvement
> Reporter: Mikhail Loenko
> Assignee: Tim Ellison
> Attachments: patch.txt
>
> As it was discussed in the mail threads PerfromanceTest class should be removed from hierarchy of unit tests in security2,
> the tests should extend TestCase class.
> The tests should be refactored to remove redundant logging that is currently done via PerformanceTest.
> I'm going to provide a patch in a day or two
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-55) remove PerformanceTest from hierarchy
of unit tests in security2
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-55?page=all ]
Tim Ellison reassigned HARMONY-55:
----------------------------------
Assign To: Tim Ellison
> remove PerformanceTest from hierarchy of unit tests in security2
> ----------------------------------------------------------------
>
> Key: HARMONY-55
> URL: http://issues.apache.org/jira/browse/HARMONY-55
> Project: Harmony
> Type: Improvement
> Reporter: Mikhail Loenko
> Assignee: Tim Ellison
> Attachments: patch.txt
>
> As it was discussed in the mail threads PerfromanceTest class should be removed from hierarchy of unit tests in security2,
> the tests should extend TestCase class.
> The tests should be refactored to remove redundant logging that is currently done via PerformanceTest.
> I'm going to provide a patch in a day or two
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-55) remove PerformanceTest from hierarchy
of unit tests in security2
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-55?page=all ]
Tim Ellison closed HARMONY-55:
------------------------------
Thanks Mikhail. I've removed PerformanceTest.java in repo revision 373799.
> remove PerformanceTest from hierarchy of unit tests in security2
> ----------------------------------------------------------------
>
> Key: HARMONY-55
> URL: http://issues.apache.org/jira/browse/HARMONY-55
> Project: Harmony
> Type: Improvement
> Reporter: Mikhail Loenko
> Assignee: Tim Ellison
> Attachments: patch.txt
>
> As it was discussed in the mail threads PerfromanceTest class should be removed from hierarchy of unit tests in security2,
> the tests should extend TestCase class.
> The tests should be refactored to remove redundant logging that is currently done via PerformanceTest.
> I'm going to provide a patch in a day or two
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-55) remove PerformanceTest from
hierarchy of unit tests in security2
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-55?page=comments#action_12364563 ]
Mikhail Loenko commented on HARMONY-55:
---------------------------------------
Tests from the security2 passed
They do not call 'logln' and do not extend 'PerformanceTest'
This class can be now removed:
modules\security2\test\common\unit\org\apache\harmony\security\test\PerformanceTest.java
Some tests will require more refactoring once a consensus about
'[testing] code for exotic configurations' is got. it likely will be a separate issue
So I think, this issue can be closed
> remove PerformanceTest from hierarchy of unit tests in security2
> ----------------------------------------------------------------
>
> Key: HARMONY-55
> URL: http://issues.apache.org/jira/browse/HARMONY-55
> Project: Harmony
> Type: Improvement
> Reporter: Mikhail Loenko
> Assignee: Tim Ellison
> Attachments: patch.txt
>
> As it was discussed in the mail threads PerfromanceTest class should be removed from hierarchy of unit tests in security2,
> the tests should extend TestCase class.
> The tests should be refactored to remove redundant logging that is currently done via PerformanceTest.
> I'm going to provide a patch in a day or two
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira