You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/01/04 07:00:49 UTC
[GitHub] [kylin] wolfboys opened a new pull request #1536: KYLIN-4855 kylin.metrics.prefix bug fix
wolfboys opened a new pull request #1536:
URL: https://github.com/apache/kylin/pull/1536
## Proposed changes
After executed "system-cube.sh cron", the system cube will be added to the crontab, but the cube name is wrong, and it does not match the actual situation. After testing, it is found that the system-cube is
There is a bug in the handling of kylin metrics prefix
In system-cube.sh, the prefix is "KYLIN". The logic is wrong. You should get "kylin.metrics.prefix" from kylin.properties. If this item is set, take the value set by the user, if not set, go to the default value. "KYLIN"
In bin/build-incremental-cube.sh The username and password default value ADMIN:KYLIN, if the password has been changed, it will not work
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN-4855), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io commented on pull request #1536: KYLIN-4855 kylin.metrics.prefix bug fix
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1536:
URL: https://github.com/apache/kylin/pull/1536#issuecomment-753974549
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1536?src=pr&el=h1) Report
> Merging [#1536](https://codecov.io/gh/apache/kylin/pull/1536?src=pr&el=desc) (be98fd8) into [master](https://codecov.io/gh/apache/kylin/commit/47f8e54558d885f384f5d98c419cc1fa532bca7b?el=desc) (47f8e54) will **decrease** coverage by `0.09%`.
> The diff coverage is `1.23%`.
[](https://codecov.io/gh/apache/kylin/pull/1536?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1536 +/- ##
============================================
- Coverage 25.51% 25.41% -0.10%
+ Complexity 6765 6763 -2
============================================
Files 1505 1508 +3
Lines 93632 93918 +286
Branches 13117 13158 +41
============================================
- Hits 23886 23872 -14
- Misses 67370 67664 +294
- Partials 2376 2382 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1536?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.46% <0.00%> (-0.05%)` | `51.00 <0.00> (ø)` | |
| [...n/java/org/apache/kylin/common/util/ClassUtil.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NsYXNzVXRpbC5qYXZh) | `49.20% <0.00%> (-2.47%)` | `9.00 <0.00> (ø)` | |
| [.../java/org/apache/kylin/job/util/JobRestClient.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL0pvYlJlc3RDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...che/kylin/engine/spark/SparkMergingDictionary.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtNZXJnaW5nRGljdGlvbmFyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/kylin/query/relnode/OLAPAggregateRel.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUEFnZ3JlZ2F0ZVJlbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/kylin/query/relnode/OLAPFilterRel.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUEZpbHRlclJlbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/kylin/query/relnode/OLAPWindowRel.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUFdpbmRvd1JlbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../query/relnode/visitor/TupleExpressionVisitor.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUV4cHJlc3Npb25WaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...torage/hbase/steps/HBaseFlinkOutputTransition.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZUZsaW5rT3V0cHV0VHJhbnNpdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/kylin/storage/hbase/steps/HBaseFlinkSteps.java](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZUZsaW5rU3RlcHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/kylin/pull/1536/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1536?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1536?src=pr&el=footer). Last update [5c12d08...be98fd8](https://codecov.io/gh/apache/kylin/pull/1536?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian commented on pull request #1536: KYLIN-4855 kylin.metrics.prefix bug fix
Posted by GitBox <gi...@apache.org>.
zhangayqian commented on pull request #1536:
URL: https://github.com/apache/kylin/pull/1536#issuecomment-782604005
LGTM and test passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1536: KYLIN-4855 kylin.metrics.prefix bug fix
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1536:
URL: https://github.com/apache/kylin/pull/1536#issuecomment-783071773
Thanks @wolfboys for contributions, thanks @zhangayqian for verification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1536: KYLIN-4855 kylin.metrics.prefix bug fix
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1536:
URL: https://github.com/apache/kylin/pull/1536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1536: KYLIN-4855 kylin.metrics.prefix bug fix
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1536:
URL: https://github.com/apache/kylin/pull/1536#issuecomment-754555840
Good job @wolfboys , I will check it later!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org