You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Parth Chandra <pc...@maprtech.com> on 2014/10/22 07:52:06 UTC
Review Request 27019: C++Client does not handle incoming record
batches with zero records
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27019/
-----------------------------------------------------------
Review request for drill and Mehant Baid.
Repository: drill-git
Description
-------
Client may get record batches that contain no rows. The c++ client still tried to build the value vectors without checking if there were no rows and the code would assert.
Diffs
-----
contrib/native/client/example/querySubmitter.cpp 040f9d7
contrib/native/client/src/clientlib/drillClientImpl.cpp 2f27b48
contrib/native/client/src/clientlib/recordBatch.cpp dfa12fd
contrib/native/client/src/include/drill/recordBatch.hpp de65202
Diff: https://reviews.apache.org/r/27019/diff/
Testing
-------
Build and tested a query with zero records returned on Windows/Linux/Mac
Thanks,
Parth Chandra
Re: Review Request 27019: C++Client does not handle incoming record
batches with zero records
Posted by Xiao Meng <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27019/#review58853
-----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp
<https://reviews.apache.org/r/27019/#comment100006>
Why put a warning here? If we recieved a record batch, then it should not contain QueryState message, at least for now.
- Xiao Meng
On Oct. 22, 2014, 5:52 a.m., Parth Chandra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27019/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 5:52 a.m.)
>
>
> Review request for drill and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Client may get record batches that contain no rows. The c++ client still tried to build the value vectors without checking if there were no rows and the code would assert.
>
>
> Diffs
> -----
>
> contrib/native/client/example/querySubmitter.cpp 040f9d7
> contrib/native/client/src/clientlib/drillClientImpl.cpp 2f27b48
> contrib/native/client/src/clientlib/recordBatch.cpp dfa12fd
> contrib/native/client/src/include/drill/recordBatch.hpp de65202
>
> Diff: https://reviews.apache.org/r/27019/diff/
>
>
> Testing
> -------
>
> Build and tested a query with zero records returned on Windows/Linux/Mac
>
>
> Thanks,
>
> Parth Chandra
>
>
Re: Review Request 27019: DRILL-1566 C++Client does not handle
incoming record batches with zero records
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27019/#review59006
-----------------------------------------------------------
Ship it!
Ship It!
- Mehant Baid
On Oct. 28, 2014, 9:22 p.m., Parth Chandra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27019/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 9:22 p.m.)
>
>
> Review request for drill and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Client may get record batches that contain no rows. The c++ client still tried to build the value vectors without checking if there were no rows and the code would assert.
>
>
> Diffs
> -----
>
> contrib/native/client/example/querySubmitter.cpp 040f9d7
> contrib/native/client/src/clientlib/drillClientImpl.cpp 2f27b48
> contrib/native/client/src/clientlib/recordBatch.cpp dfa12fd
> contrib/native/client/src/include/drill/recordBatch.hpp de65202
>
> Diff: https://reviews.apache.org/r/27019/diff/
>
>
> Testing
> -------
>
> Build and tested a query with zero records returned on Windows/Linux/Mac
>
>
> Thanks,
>
> Parth Chandra
>
>
Re: Review Request 27019: DRILL-1566 C++Client does not handle
incoming record batches with zero records
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27019/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 9:22 p.m.)
Review request for drill and Mehant Baid.
Summary (updated)
-----------------
DRILL-1566 C++Client does not handle incoming record batches with zero records
Repository: drill-git
Description
-------
Client may get record batches that contain no rows. The c++ client still tried to build the value vectors without checking if there were no rows and the code would assert.
Diffs
-----
contrib/native/client/example/querySubmitter.cpp 040f9d7
contrib/native/client/src/clientlib/drillClientImpl.cpp 2f27b48
contrib/native/client/src/clientlib/recordBatch.cpp dfa12fd
contrib/native/client/src/include/drill/recordBatch.hpp de65202
Diff: https://reviews.apache.org/r/27019/diff/
Testing
-------
Build and tested a query with zero records returned on Windows/Linux/Mac
Thanks,
Parth Chandra
Re: Review Request 27019: C++Client does not handle incoming record
batches with zero records
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27019/#review58856
-----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp
<https://reviews.apache.org/r/27019/#comment100011>
True, it's not a warning. I can change this to an Info or debug messge.
- Parth Chandra
On Oct. 22, 2014, 5:52 a.m., Parth Chandra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27019/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 5:52 a.m.)
>
>
> Review request for drill and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Client may get record batches that contain no rows. The c++ client still tried to build the value vectors without checking if there were no rows and the code would assert.
>
>
> Diffs
> -----
>
> contrib/native/client/example/querySubmitter.cpp 040f9d7
> contrib/native/client/src/clientlib/drillClientImpl.cpp 2f27b48
> contrib/native/client/src/clientlib/recordBatch.cpp dfa12fd
> contrib/native/client/src/include/drill/recordBatch.hpp de65202
>
> Diff: https://reviews.apache.org/r/27019/diff/
>
>
> Testing
> -------
>
> Build and tested a query with zero records returned on Windows/Linux/Mac
>
>
> Thanks,
>
> Parth Chandra
>
>