You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/04/18 02:26:10 UTC
Review Request 33327: DRILL-2815: Some PathScanner logging,
misc. cleanup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33327/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2815
https://issues.apache.org/jira/browse/DRILL-2815
Repository: drill-git
Description
-------
Added some DEBUG-level log calls and augmented, edited log message.
Misc. code "hygiene":
- Added method doc comment.
- Added "final".
- Fixed indentation; wrapped some long lines.
Diffs
-----
common/src/main/java/org/apache/drill/common/util/PathScanner.java 730c770
Diff: https://reviews.apache.org/r/33327/diff/
Testing
-------
Ran tests.
Thanks,
Daniel Barclay
Re: Review Request 33327: DRILL-2815: Some PathScanner logging,
misc. cleanup.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33327/
-----------------------------------------------------------
(Updated May 20, 2015, 10:02 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2815
https://issues.apache.org/jira/browse/DRILL-2815
Repository: drill-git
Description (updated)
-------
Added some DEBUG-level log calls and augmented, edited log message.
Misc. code "hygiene":
- Added method doc comment.
- Renamed to clarify a number of names.
- Added "final".
- Fixed indentation; wrapped some long lines.
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/util/PathScanner.java 730c770
Diff: https://reviews.apache.org/r/33327/diff/
Testing (updated)
-------
Ran existing tests; no new errors.
Thanks,
Daniel Barclay
Re: Review Request 33327: DRILL-2815: Some PathScanner logging,
misc. cleanup.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33327/
-----------------------------------------------------------
(Updated April 20, 2015, 3:04 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Just removed a space from Git commit comment.
Bugs: DRILL-2815
https://issues.apache.org/jira/browse/DRILL-2815
Repository: drill-git
Description
-------
Added some DEBUG-level log calls and augmented, edited log message.
Misc. code "hygiene":
- Added method doc comment.
- Added "final".
- Fixed indentation; wrapped some long lines.
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/util/PathScanner.java 730c770
Diff: https://reviews.apache.org/r/33327/diff/
Testing
-------
Ran tests.
Thanks,
Daniel Barclay