You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:38:20 UTC
[GitHub] [lucene] mocobeta opened a new pull request #387: Specify minimum required python version for dev scripts
mocobeta opened a new pull request #387:
URL: https://github.com/apache/lucene/pull/387
As far as I know, dev scripts require python 3.3 or above.
`subprocess.TimeoutError` was introduced in 3.3.
https://docs.python.org/3/library/subprocess.html#subprocess.TimeoutExpired
https://github.com/apache/lucene/blob/f38c401283c43b17fa5c63b4da0a9ffc13660bc4/dev-tools/scripts/buildAndPushRelease.py#L25
It may be better to explicitly specify the minimum required version.
(When introducing newly added APIs in 3.4 or above, the minimum required version should be also maintained; I think it's a good convention to avoid unnecessary conflicts. Some common utility to check interpreter version would be more desirable though...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #387: Specify minimum required python version for dev scripts
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #387:
URL: https://github.com/apache/lucene/pull/387#issuecomment-945038306
@janhoy Thanks, I will update to 3.6 since I don't see a good reason to stick old version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #387: Specify minimum required python version for dev scripts
Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #387:
URL: https://github.com/apache/lucene/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #387: Specify minimum required python version for dev scripts
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #387:
URL: https://github.com/apache/lucene/pull/387#issuecomment-944825323
Do we need a jira issue or dev-list post for this...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org