[jira] [Resolved] (SOLR-13030) MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?

["Cassandra Targett (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cassandra Targett resolved SOLR-13030.
--------------------------------------
    Fix Version/s: 8.0
       Resolution: Fixed

I'll take a cue from David's comment that this probably should have been closed for 8.0, but at this point the test has been removed from Solr so if there was anything else to do here, there isn't now.

> MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-13030
>                 URL: https://issues.apache.org/jira/browse/SOLR-13030
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Chris M. Hostetter
>            Assignee: Mark Miller
>            Priority: Major
>             Fix For: 8.0
>
>
> {{MetricsHistoryHandler}} implements {{Closeable}} and depends on it's {{close()}} method to shutdown a {{private ScheduledThreadPoolExecutor collectService}} as well as a {{private final SolrRrdBackendFactory factory}} (which maintains it's own {{private ScheduledThreadPoolExecutor}} but -as far as i can tell nothing seems to every "close" this {{MetricsHistoryHandler}} on shutdown.- after changes in 75b1831967982 which move this close() call to a {{ForkJoinPool}} in {{CoreContainer.shutdown()}} it seems to be leaking threads.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org