You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/06/03 01:05:01 UTC

[jira] [Commented] (CURATOR-110) LeaderLatch does not complete if it is started without a connection to ZooKeeper

    [ https://issues.apache.org/jira/browse/CURATOR-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016018#comment-14016018 ] 

ASF GitHub Bot commented on CURATOR-110:
----------------------------------------

GitHub user cammckenzie opened a pull request:

    https://github.com/apache/curator/pull/9

    Curator 110

    Fix for CURATOR-110

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cammckenzie/curator CURATOR-110

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit 1a63a102ebbaaead265babd71a3d52928f848bd0
Author: Cameron McKenzie <ca...@unico.com.au>
Date:   2014-06-02T06:30:26Z

    CURATOR-110 - Modified state handling to treat 'CONNECTED' and
    'RECONNECTED' events in the same way. Added a test case for the leader
    latch being started before a connection to ZK has been established.

commit 0b7ae7e3672a9c817fe31144cd6b18d9a357f124
Author: Cameron McKenzie <ca...@unico.com.au>
Date:   2014-06-02T23:01:31Z

    CURATOR-110 - Fixed up formatting to Curator standards

----


> LeaderLatch does not complete if it is started without a connection to ZooKeeper
> --------------------------------------------------------------------------------
>
>                 Key: CURATOR-110
>                 URL: https://issues.apache.org/jira/browse/CURATOR-110
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.5.0
>            Reporter: Cameron McKenzie
>            Priority: Minor
>              Labels: connection, latch, leader
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Given the following conditions:
> 1.) No connection is available to ZK
> 2.) A LeaderLatch is created and started
> 3.) All retries for the leader latch creating its ephemeral zNode have been exhausted.
> At this point the LeaderLatch will not begin functioning correctly when a connection is established. This is due to it ignoring 'CONNECTED' connection state events (it only handles RECONNECTED events).
> The fix should simply be a case of making the state handling for CONNECTED and RECONNECTED the same.



--
This message was sent by Atlassian JIRA
(v6.2#6252)