You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "josedee (via GitHub)" <gi...@apache.org> on 2026/08/31 13:41:23 UTC
Re: [PR] [incubator-kie-6902] Inherit the platform versions from the kie stack BOMs (Quarkus and Spring Boot examples) [incubator-kie-examples]
josedee commented on code in PR #2244:
URL: https://github.com/apache/incubator-kie-examples/pull/2244#discussion_r3894882937
##########
kogito-quarkus-examples/kogito-travel-agency/pom.xml:
##########
@@ -35,20 +35,9 @@
<module>extended</module>
</modules>
<properties>
- <quarkus-plugin.version>3.27.5.1</quarkus-plugin.version>
- <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
- <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
- <quarkus.platform.version>3.27.5.1</quarkus.platform.version>
Review Comment:
This block is empty and could be removed
##########
kogito-quarkus-examples/kogito-travel-agency/pom.xml:
##########
@@ -35,20 +35,9 @@
<module>extended</module>
</modules>
<properties>
- <quarkus-plugin.version>3.27.5.1</quarkus-plugin.version>
- <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
- <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
- <quarkus.platform.version>3.27.5.1</quarkus.platform.version>
</properties>
<dependencyManagement>
<dependencies>
- <dependency>
- <groupId>${quarkus.platform.group-id}</groupId>
- <artifactId>${quarkus.platform.artifact-id}</artifactId>
- <version>${quarkus.platform.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
</dependencies>
</dependencyManagement>
Review Comment:
This block is empty and could be removed
##########
kogito-springboot-examples/pom.xml:
##########
@@ -24,26 +24,124 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
+ <!-- The Spring Boot examples inherit from the Kogito Spring Boot BOM so that the Spring Boot platform version, the
+ spring-boot-maven-plugin version and the Spring Boot-targeted dependency management are all taken from the
+ single place that defines them on the kie side. No Spring Boot version is declared in the Maven examples (the Gradle examples keep their own literal pins in
+ gradle.properties: Gradle cannot inherit from a Maven parent).
+
+ A pom has a single parent, so this aggregator does not inherit from the examples root
+ (kogito-examples), which is a plain module list. The build configuration below (test wiring,
+ container properties, packaging manifests, reproducible-build settings, project metadata) is the
+ examples' shared configuration; kogito-quarkus-examples and kogito-springboot-examples each carry
+ it and must be kept in sync. -->
<parent>
- <groupId>org.kie.kogito.examples</groupId>
- <artifactId>kogito-examples</artifactId>
+ <groupId>org.kie.kogito</groupId>
+ <artifactId>kogito-spring-boot-bom</artifactId>
<version>999-SNAPSHOT</version>
+ <relativePath/>
</parent>
+ <groupId>org.kie.kogito.examples</groupId>
<artifactId>kogito-springboot-examples</artifactId>
<packaging>pom</packaging>
<name>Kogito Example :: Spring Boot</name>
+ <description>Kogito Example :: Spring Boot</description>
+
+ <url>http://kogito.kie.org/kogito-springboot-examples</url>
+ <inceptionYear>2019</inceptionYear>
+ <organization>
+ <name>The Apache Software Foundation</name>
+ <url>https://apache.org/</url>
+ </organization>
+
+ <licenses>
+ <license>
+ <name>Apache Software License, Version 2.0</name>
+ <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
+ <distribution>repo</distribution>
+ </license>
+ </licenses>
+
+ <scm>
+ <connection>scm:git:https://github.com/apache/incubator-kie-examples.git/kogito-springboot-examples</connection>
+ <developerConnection>scm:git:https://github.com/apache/incubator-kie-examples.git/kogito-springboot-examples</developerConnection>
+ <url>https://github.com/apache/incubator-kie-examples/kogito-springboot-examples</url>
+ </scm>
+
+ <developers>
+ <developer>
+ <name>The Apache KIE Team</name>
+ <email>dev@kie.apache.org</email>
+ <url>https://kie.apache.org</url>
+ <organization>Apache Software Foundation</organization>
+ <organizationUrl>http://apache.org/</organizationUrl>
+ </developer>
+ </developers>
+
+ <mailingLists>
+ <mailingList>
+ <name>Development List</name>
+ <subscribe>dev-subscribe@kie.apache.org</subscribe>
+ <unsubscribe>dev-unsubscribe@kie.apache.org</unsubscribe>
+ <post>dev@kie.apache.org</post>
+ <archive>https://lists.apache.org/list.html?dev@kie.apache.org</archive>
+ </mailingList>
+ <mailingList>
+ <name>User List</name>
+ <subscribe>users-subscribe@kie.apache.org</subscribe>
+ <unsubscribe>users-unsubscribe@kie.apache.org</unsubscribe>
+ <post>users@kie.apache.org</post>
+ <archive>https://lists.apache.org/list.html?users@kie.apache.org</archive>
+ </mailingList>
+ <mailingList>
+ <name>Commits List</name>
+ <subscribe>commits-subscribe@kie.apache.org</subscribe>
+ <unsubscribe>commits-unsubscribe@kie.apache.org</unsubscribe>
+ <post>commits@kie.apache.org</post>
+ <archive>https://lists.apache.org/list.html?commits@kie.apache.org</archive>
+ </mailingList>
+ </mailingLists>
<properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <version.org.kie.kogito>999-SNAPSHOT</version.org.kie.kogito>
+
+ <surefire.forkCount>1</surefire.forkCount>
+ <failsafe.include>**/*IT.java</failsafe.include>
+ <failsafe.exclude>**/Native*IT.java</failsafe.exclude>
+ <alphanetworkCompilerEnabled>false</alphanetworkCompilerEnabled>
+ <tests.category></tests.category>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Review Comment:
Duplicate with line 106
##########
kogito-springboot-examples/pom.xml:
##########
@@ -154,9 +269,222 @@
<pluginManagement>
<plugins>
<plugin>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-maven-plugin</artifactId>
- <version>${version.org.springframework.boot}</version>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>2.5</version>
Review Comment:
```suggestion
<version>${version.resources.plugin}</version>
```
I think we need to get it from BOM rather than hardcoding
##########
kogito-quarkus-examples/kogito-travel-agency/extended/pom.xml:
##########
@@ -35,20 +35,9 @@
<module>visas</module>
</modules>
<properties>
- <quarkus-plugin.version>3.27.5.1</quarkus-plugin.version>
- <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
- <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
- <quarkus.platform.version>3.27.5.1</quarkus.platform.version>
</properties>
<dependencyManagement>
<dependencies>
- <dependency>
- <groupId>${quarkus.platform.group-id}</groupId>
- <artifactId>${quarkus.platform.artifact-id}</artifactId>
- <version>${quarkus.platform.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
</dependencies>
</dependencyManagement>
Review Comment:
Could be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org