You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/08/29 00:32:28 UTC

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the DOWN mode.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37358/
-----------------------------------------------------------

(Updated Aug. 28, 2015, 3:32 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Changes
-------

Rebase + changes to match previous reviews in chain.
Renamed endpoint to match the renamed `DOWN` mode.


Summary (updated)
-----------------

Maintenance Primitives: Adds an endpoint for transitioning agents into the DOWN mode.


Bugs: MESOS-2067 and MESOS-3069
    https://issues.apache.org/jira/browse/MESOS-2067
    https://issues.apache.org/jira/browse/MESOS-3069


Repository: mesos


Description (updated)
-------

Endpoint: /machine/down

Registry operation = maintenance::StartMaintenance
  Sets the list of machines as Down.


Diffs (updated)
-----

  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/master/maintenance.hpp PRE-CREATION 
  src/master/maintenance.cpp PRE-CREATION 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 
  src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 

Diff: https://reviews.apache.org/r/37358/diff/


Testing (updated)
-------

`make check`

New Tests:
  RegistrarTest.StartMaintenance
    Schedules some machines.  Downs some.
  MasterMaintenanceTest.BringDownMachines
    Tests some invalid lists.
    Schedules some machines.  Tests some valid and invalid lists.


Thanks,

Joseph Wu