You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/28 08:54:03 UTC

[GitHub] [incubator-doris] sduzh removed a comment on pull request #4965: Clang-format cpp sources

sduzh removed a comment on pull request #4965:
URL: https://github.com/apache/incubator-doris/pull/4965#issuecomment-735142455


   > Still has compilation error like:
   > 
   > ```
   > 812 /home/disk1/cmy/git/doris/core/be/src/olap/rowset/segment_v2/options.h:27:14: error: ‘size_t’ does not name a type; did you mean ‘__size_t’?
   > 813  static const size_t DEFAULT_PAGE_SIZE = 1024 * 1024; // default size: 1M
   > 814               ^~~~~~
   > 815               __size_t
   > 816 /home/disk1/cmy/git/doris/core/be/src/olap/rowset/segment_v2/options.h:30:5: error: ‘size_t’ does not name a type; did you mean ‘__size_t’?
   > 817      size_t data_page_size = DEFAULT_PAGE_SIZE;
   > 818      ^~~~~~
   > 819      __size_t
   > 820 /home/disk1/cmy/git/doris/core/be/src/olap/rowset/segment_v2/options.h:32:5: error: ‘size_t’ does not name a type; did you mean ‘__size_t’?
   > 821      size_t dict_page_size = DEFAULT_PAGE_SIZE;
   > 822      ^~~~~~
   > 823      __size_t
   > ```
   > 
   > and
   > 
   > ```
   > 826 /home/disk1/cmy/git/doris/core/be/test/olap/rowset/segment_v2/rle_page_test.cpp:59:25: error: ‘struct doris::segment_v2::PageBuilderOptions’ has no member named ‘data_page_size’
   > 827          builder_options.data_page_size = 256 * 1024;
   > 828                          ^~~~~~~~~~~~~~
   > 829 /home/disk1/cmy/git/doris/core/be/test/olap/rowset/segment_v2/rle_page_test.cpp: In member function ‘virtual void doris::RlePageTest_TestRleInt32BlockEncoderSize_Test::TestBody()’:
   > 830 /home/disk1/cmy/git/doris/core/be/test/olap/rowset/segment_v2/rle_page_test.cpp:161:21: error: ‘struct doris::segment_v2::PageBuilderOptions’ has no member named ‘data_page_size’
   > 831      builder_options.data_page_size = 256 * 1024;
   > 832                      ^~~~~~~~~~~~~~
   > 833 /home/disk1/cmy/git/doris/core/be/test/olap/rowset/segment_v2/rle_page_test.cpp: In member function ‘virtual void doris::RlePageTest_TestRleBoolBlockEncoderSize_Test::TestBody()’:
   > 834 /home/disk1/cmy/git/doris/core/be/test/olap/rowset/segment_v2/rle_page_test.cpp:197:21: error: ‘struct doris::segment_v2::PageBuilderOptions’ has no member named ‘data_page_size’
   > 835      builder_options.data_page_size = 256 * 1024;
   > 836                      ^~~~~~~~~~~~~~
   > ```
   > 
   > Please run `sh run-be-ut.sh --run` in your local env.
   > 
   > And you need to rebase the master to solve a compilation error in FE.
   
   The undeclared `size_t ` problem fixed already in this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org