You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/04 18:14:57 UTC

[GitHub] [solr] epugh commented on a diff in pull request #924: SOLR-16276: redundant variable in tests

epugh commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913194604


##########
solr/core/src/test/org/apache/solr/cloud/ReindexCollectionTest.java:
##########
@@ -167,24 +167,23 @@ public void testSameTargetReindexing() throws Exception {
 
   private void doTestSameTargetReindexing(boolean sourceRemove, boolean followAliases)
       throws Exception {
-    final String sourceCollection = "sameTargetReindexing_" + sourceRemove + "_" + followAliases;
-    final String targetCollection = sourceCollection;

Review Comment:
   agreed...   changing this back...  Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org