[PATCH] SSI support

[Paul Speed <ps...@progeeks.com>]

Hello,

I realize Bip is away, but I thought I'd post these anyway before I
forget about them.  Since I've had problems with multiple attachments
I went ahead and stuck the files on my web site at:

http://www.progeeks.com/pspeed/tomcat/SSIPatches.html

Each file has a description of what it contains and where it should
go.  If a committer chooses to apply them and has problems then let
me know.

Here is the description of the changes from the above-linked page:

>
> What I did...
> 
> The changes to SsiInvokerServlet should be independent of the other 
> changes. Really, I just improved parsing support to handle escaped
> characters, etc. and be more error-compatible with Apache.
>
> The other SSI commands were modified to be more compatible with 
> Apache SSI. Specifically, I've verified that the supported tags
> should work the same as mod_include in Apache 1.3.22. At least they
> support the same options. The tags were also enhanced to fit with the
> new conditional tags.
>
> I also added the implementation of the conditional tags: "if", 
> "elif", "else", and "endif". This includes an expression parser. 
> It's been a while since I've written a parser and I tried to do it
> with a slant on understandability. There's probably room for
> improvement, but it works the same as Apache on all of the tests
> I've tried... and it passed all of the new tester pages which
> generate identical output to Apache 1.3.22.
>
> So after these patches, the only tags that are missing that
> mod_include has are "printenv" and "perl" (which is conditionally
> included anyway).  Also, the "encoding" parameter on "echo" is
> silently ignored right now.
>

Thanks,
-Paul Speed

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

[PATCH] SSI support

[Paul Speed <ps...@progeeks.com>]

Hello,

I'm posting my SSI patches again since the CVS versions have changed
since I last posted them.  This latest version has Amy Roh's most
recent changes merged into it.  The description is the same as in the
quoted e-mail.  I'm going ahead and including all.zip which contains
the various patches in case the nice committer that gets to this 
doesn't feel like hitting the web link. :)  Here is the description 
of what all.zip contains (also from the web page linked below):

SsiInvokerServlet.diff
diff -u output for the org.apache.catalina.servlets.SsiInvokerServlet.
This patch should be independent of the others since it just fixes
some SSI directive parsing issues. 

new_classes.zip 
4 new .java files for the org.apache.catalina.util.ssi package. 
Note: I did not add apache headers to these files since I
     didn't think it was appropriate for a non-committer to do so. 

util_ssi.diff 
The diff -u output for many of the other files in the 
org.apache.catalina.util.ssi package. 

tester_web.zip 
New files for the tester/web directory. Includes files for the 
tester/web/golden directory as well... all relative to tester/web. 

tester.diff 
diff -u output for src/bin/tester.xml. It adds the appropriate 
directives for the tests added from tester_web.zip. 

My interest in seeing these changes committed is two-fold:
1) I'd like to know if there are any problems that may require
   my help to resolve.
2) I have some additional changes I'd like to propose at some
   point but I don't want to make my patch set any larger than
   it already is. :)  Specifically, I want to lock down the
   "exec" directive so that SSI can be safely/securely deployed by 
   default.

If someone looks at this stuff and finds something wrong, then
please let me know.  Thanks.
-Paul Speed

Paul Speed wrote:
> 
> Hello,
> 
> I realize Bip is away, but I thought I'd post these anyway before I
> forget about them.  Since I've had problems with multiple attachments
> I went ahead and stuck the files on my web site at:
> 
> http://www.progeeks.com/pspeed/tomcat/SSIPatches.html
> 
> Each file has a description of what it contains and where it should
> go.  If a committer chooses to apply them and has problems then let
> me know.
> 
> Here is the description of the changes from the above-linked page:
> 
> >
> > What I did...
> >
> > The changes to SsiInvokerServlet should be independent of the other
> > changes. Really, I just improved parsing support to handle escaped
> > characters, etc. and be more error-compatible with Apache.
> >
> > The other SSI commands were modified to be more compatible with
> > Apache SSI. Specifically, I've verified that the supported tags
> > should work the same as mod_include in Apache 1.3.22. At least they
> > support the same options. The tags were also enhanced to fit with the
> > new conditional tags.
> >
> > I also added the implementation of the conditional tags: "if",
> > "elif", "else", and "endif". This includes an expression parser.
> > It's been a while since I've written a parser and I tried to do it
> > with a slant on understandability. There's probably room for
> > improvement, but it works the same as Apache on all of the tests
> > I've tried... and it passed all of the new tester pages which
> > generate identical output to Apache 1.3.22.
> >
> > So after these patches, the only tags that are missing that
> > mod_include has are "printenv" and "perl" (which is conditionally
> > included anyway).  Also, the "encoding" parameter on "echo" is
> > silently ignored right now.
> >
> 
> Thanks,
> -Paul Speed
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>