[jira] [Commented] (KAFKA-373) Broker Failure Test needs to be fixed to work with Mirror Maker in TRUNK

["Joel Koshy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399781#comment-13399781 ] 

Joel Koshy commented on KAFKA-373:
----------------------------------

John, thanks for the patch.  Some of these comments would also apply to the
test in 0.8:

- The header of the script is mostly in the README which is more
  appropriate. i.e., we should just have a README.
- Non-blocker: I think it would be good to switch to getopt for the test
  parameters - I think we should do this in our system tests going forward...  and some
  of the variable parameters in the script (i.e., the ones you mark as
  "change as needed") can be made command-line parameters.
- The script is getting to be big, so a number of functions can/should be
  collapsed, and use arguments to handle the variants:
  - wait_for_zero.. functions
  - start_source/target cluster/server functions
  - start_console_consumer functions
- Shouldn't shutdown_producer do a kill_child_processes? in which case why
  have the file to notify? FWIW, there's some bug in the script's shutdown -
  don't remember what I did, but I had run the system test in 0.8 and my
  hard-disk was full in the morning.
- Not sure why you need to check the num_iterations ge iter inside the
  start_test loop - also you can move the increment outside those blocks -
  or switch to a for loop over a range.
- I don't think you need to sleep after starting the mirror makers.
- Can you elaborate on the hanging console consumer/mirror maker issue?

                
> Broker Failure Test needs to be fixed to work with Mirror Maker in TRUNK
> ------------------------------------------------------------------------
>
>                 Key: KAFKA-373
>                 URL: https://issues.apache.org/jira/browse/KAFKA-373
>             Project: Kafka
>          Issue Type: Task
>            Reporter: John Fung
>            Assignee: John Fung
>         Attachments: kafka-373-v1.patch
>
>
> Embedded consumer is no longer supported and Mirror Maker is introduced to TRUNK. Broker Failure test needs to be fixed to use Mirror Maker for mirroring.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira