You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/30 05:52:29 UTC

[GitHub] [spark] huaxingao opened a new pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

huaxingao opened a new pull request #29581:
URL: https://github.com/apache/spark/pull/29581


   
   ### What changes were proposed in this pull request?
   Override the default SQL strings for 
   
   - ALTER TABLE ADD COLUMN
   - ALTER TABLE RENAME COLUMN
   - ALTER TABLE DROP COLUMN
   - ALTER TABLE UPDATE COLUMN TYPE
   - ALTER TABLE UPDATE COLUMN NULLABILITY
   
   in the following JDBC dialects according to official documentation:
   
   - DB2
   - Derby
   - MS SQL Server
   - MYSQL
   - Oracle
   - Postgres
   - Teradata
   
   
   ### Why are the changes needed?
   To have correct implementation of alter table for all supported JDBC dialects.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Manually check the SQL strings are built correctly
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683465589


   **[Test build #128049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128049/testReport)** for PR 29581 at commit [`3ae04d4`](https://github.com/apache/spark/commit/3ae04d4bba0e5de244f4adaf58835cc583ad1750).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683480959


   cc @MaxGekk @cloud-fan @viirya 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683380263


   **[Test build #128031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128031/testReport)** for PR 29581 at commit [`3ae04d4`](https://github.com/apache/spark/commit/3ae04d4bba0e5de244f4adaf58835cc583ad1750).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683465872






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683385057


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128031/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683435489


   **[Test build #128049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128049/testReport)** for PR 29581 at commit [`3ae04d4`](https://github.com/apache/spark/commit/3ae04d4bba0e5de244f4adaf58835cc583ad1750).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683380330






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-685233976


   `Can we have docker tests for these databases with JDBC v2?`
   Sorry, busy days. Didn't have a chance to work on this yet, but I will.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683435087


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683380263


   **[Test build #128031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128031/testReport)** for PR 29581 at commit [`3ae04d4`](https://github.com/apache/spark/commit/3ae04d4bba0e5de244f4adaf58835cc583ad1750).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683385035


   **[Test build #128031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128031/testReport)** for PR 29581 at commit [`3ae04d4`](https://github.com/apache/spark/commit/3ae04d4bba0e5de244f4adaf58835cc583ad1750).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683435629






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683465872






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683380330






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683435629






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683385055






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao closed pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #29581:
URL: https://github.com/apache/spark/pull/29581


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-701362519


   I propose to open separate PR per every supported dialect with docker integration tests. Here is the PR for the Oracle dialect: https://github.com/apache/spark/pull/29912


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683627407


   Can we have docker tests for these databases with JDBC v2?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683435489


   **[Test build #128049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128049/testReport)** for PR 29581 at commit [`3ae04d4`](https://github.com/apache/spark/commit/3ae04d4bba0e5de244f4adaf58835cc583ad1750).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29581: [SPARK-32523][SQL] Override alter table in JDBC dialects

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29581:
URL: https://github.com/apache/spark/pull/29581#issuecomment-683385055


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org