You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by chengxiang li <ch...@intel.com> on 2014/11/25 10:35:38 UTC
Review Request 28435: HIVE-8959 SparkSession is not closed until JVM
exit.[Spark Branch]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28435/
-----------------------------------------------------------
Review request for hive, Szehon Ho and Xuefu Zhang.
Bugs: HIVE-8959
https://issues.apache.org/jira/browse/HIVE-8959
Repository: hive-git
Description
-------
During unit test, SparkSession is closed by Runtime shutdownHook, which means it's closed until JVM exist. During unit test suite, each qfile, as a single test case, would reset SessionState, which lead to a new Sparksession is created for each qfile. As we know that, RemoteSparkClient is SparkSession specified, so more and more executors is launched during unit test until blocked by no more resources.
Diffs
-----
itests/qtest-spark/pom.xml b31db8e
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 3f47749
Diff: https://reviews.apache.org/r/28435/diff/
Testing
-------
Thanks,
chengxiang li
Re: Review Request 28435: HIVE-8959 SparkSession is not closed until
JVM exit.[Spark Branch]
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28435/#review62973
-----------------------------------------------------------
Ship it!
Ship It!
- Xuefu Zhang
On Nov. 25, 2014, 9:35 a.m., chengxiang li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28435/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 9:35 a.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-8959
> https://issues.apache.org/jira/browse/HIVE-8959
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> During unit test, SparkSession is closed by Runtime shutdownHook, which means it's closed until JVM exist. During unit test suite, each qfile, as a single test case, would reset SessionState, which lead to a new Sparksession is created for each qfile. As we know that, RemoteSparkClient is SparkSession specified, so more and more executors is launched during unit test until blocked by no more resources.
>
>
> Diffs
> -----
>
> itests/qtest-spark/pom.xml b31db8e
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 3f47749
>
> Diff: https://reviews.apache.org/r/28435/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> chengxiang li
>
>