You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/17 00:15:20 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #485: [YUNIKORN-1213] Make the background health checker interval configurable
craigcondit opened a new pull request, #485:
URL: https://github.com/apache/yunikorn-core/pull/485
### What is this PR for?
Adds a configuration setting `health.checkInterval' to support configuration of the health checker. Setting this value to 0 or negative will disable the check completely.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1213
### How should this be tested?
Unit tests added
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #485: [YUNIKORN-1213] Make the background health checker interval configurable
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #485:
URL: https://github.com/apache/yunikorn-core/pull/485#issuecomment-1355862148
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/485?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#485](https://codecov.io/gh/apache/yunikorn-core/pull/485?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ca41f5) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/ecdf82312d88952c925c609dac473b114be6ccc4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecdf823) will **decrease** coverage by `0.01%`.
> The diff coverage is `77.98%`.
```diff
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
- Coverage 73.03% 73.01% -0.02%
==========================================
Files 69 69
Lines 10338 10410 +72
==========================================
+ Hits 7550 7601 +51
- Misses 2539 2557 +18
- Partials 249 252 +3
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/485?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/configs/configs.go](https://codecov.io/gh/apache/yunikorn-core/pull/485/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3MuZ28=) | `83.67% <ø> (ø)` | |
| [pkg/common/utils.go](https://codecov.io/gh/apache/yunikorn-core/pull/485/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy5nbw==) | `86.66% <0.00%> (-6.94%)` | :arrow_down: |
| [pkg/scheduler/scheduler.go](https://codecov.io/gh/apache/yunikorn-core/pull/485/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/yunikorn-core/pull/485/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `84.49% <87.62%> (-0.71%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #485: [YUNIKORN-1213] Make the background health checker interval configurable
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #485: [YUNIKORN-1213] Make the background health checker interval configurable
URL: https://github.com/apache/yunikorn-core/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org