You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wengzhe (via GitHub)" <gi...@apache.org> on 2023/02/03 17:00:00 UTC

[GitHub] [nuttx] wengzhe commented on a diff in pull request #8425: tools: Fix Config.mk

wengzhe commented on code in PR #8425:
URL: https://github.com/apache/nuttx/pull/8425#discussion_r1096034595


##########
tools/Config.mk:
##########
@@ -48,7 +48,7 @@ else ifeq ($(V),)
 endif
 
 ifeq ($(ECHO_BEGIN),)
-  export ECHO_BEGIN=@echo
+  export ECHO_BEGIN=@echo 

Review Comment:
   Can we add a comment here to prevent others from mis-removing it again if we choose to add trailing space here?
   ```
   export ECHO_BEGIN=@echo # keep a trailing space here
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org