You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/07/14 09:10:39 UTC
[GitHub] spark pull request #21768: [SPARK-24776][SQL]Improve Avro unit test
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/21768
[SPARK-24776][SQL]Improve Avro unit test
## What changes were proposed in this pull request?
Improve Avro unit test:
1. use QueryTest/SharedSQLContext/SQLTestUtils, instead of the duplicated test utils.
2. replace deprecated methods
This is a follow up PR for #21760, the PR passes pull request tests but failed in: https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-maven-hadoop-2.6/7842/
This PR is to fix it.
## How was this patch tested?
Unit test.
Compile with different commands:
```
./build/mvn --force -DzincPort=3643 -DskipTests -Phadoop-2.6 -Phive-thriftserver -Pkinesis-asl -Pspark-ganglia-lgpl -Pmesos -Pyarn compile test-compile
./build/mvn --force -DzincPort=3643 -DskipTests -Phadoop-2.7 -Phive-thriftserver -Pkinesis-asl -Pspark-ganglia-lgpl -Pmesos -Pyarn compile test-compile
./build/mvn --force -DzincPort=3643 -DskipTests -Phadoop-3.1 -Phive-thriftserver -Pkinesis-asl -Pspark-ganglia-lgpl -Pmesos -Pyarn compile test-compile
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark improve_avro_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21768.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21768
----
commit 26b88ca201a70283528f289cdd2e1e216fce6e7a
Author: Gengliang Wang <ge...@...>
Date: 2018-07-13T11:41:56Z
improve AvroSuite
commit 4a7e60b265688ab6a8225fc3eea2ff3ebe8aec37
Author: Gengliang Wang <ge...@...>
Date: 2018-07-14T09:02:21Z
fix compilation error
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21768: [SPARK-24776][SQL]Improve Avro unit test
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21768
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92999/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21768: [SPARK-24776][SQL]Improve Avro unit test
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21768
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21768: [SPARK-24776][SQL]Improve Avro unit test
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21768
**[Test build #92999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92999/testReport)** for PR 21768 at commit [`4a7e60b`](https://github.com/apache/spark/commit/4a7e60b265688ab6a8225fc3eea2ff3ebe8aec37).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21768: [SPARK-24776][SQL]Improve Avro unit test
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21768
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/949/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21768: [SPARK-24776][SQL]Avro unit test: deduplicates code and ...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21768
@HyukjinKwon sure, thanks for the suggestion.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21768: [SPARK-24776][SQL]Improve Avro unit test
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21768
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21768: [SPARK-24776][SQL]Improve Avro unit test
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21768
@gengliangwang, mind if I ask to fix the PR title like Deduplicates codes and replace deprecated methods in Avro unit tests?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21768: [SPARK-24776][SQL]Avro unit test: deduplicate cod...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21768
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21768: [SPARK-24776][SQL]Improve Avro unit test
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21768
**[Test build #92999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92999/testReport)** for PR 21768 at commit [`4a7e60b`](https://github.com/apache/spark/commit/4a7e60b265688ab6a8225fc3eea2ff3ebe8aec37).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org