[PR] Pci ep 0926 [nuttx]

["lipengfei28 (via GitHub)" <gi...@apache.org>]

lipengfei28 opened a new pull request, #13628:
URL: https://github.com/apache/nuttx/pull/13628

   ## Summary
   1.pci_epf_device_s and pci_epc_ctrl_s add priv data
   2.pci epf use epc_node link to epc
   3.pci epc mem use virtual mem
   4.pci_epf_driver_s use FAR const struct pci_epf_ops_s *ops
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pci ep 0926 [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #13628:
URL: https://github.com/apache/nuttx/pull/13628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pci ep 0926 [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #13628:
URL: https://github.com/apache/nuttx/pull/13628#issuecomment-2376067862

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, this PR summary does not meet the NuttX requirements.** 
   
   Here's why and how to improve it:
   
   **Summary:**
   
   * **Missing Context:** The summary is too technical and lacks crucial context. 
       * **Why are these changes necessary?** Are you fixing a bug, improving performance, or adding a new feature? 
       * **What problem does this solve for NuttX users?**
   * **Functional Description is Unclear:** 
       * What is "pci_epf_device_s"? 
       * What does "epc_node link to epc" mean? 
       * You need to explain these changes in a way that someone unfamiliar with the codebase can understand.
   * **No Issue References:**  If this PR addresses a specific issue in the NuttX repository, provide the issue number.
   
   **Impact:**
   
   * **Incomplete:** You've left all the impact sections blank. You **must** address each point:
       * **New Feature/Changes:** Clearly state if this adds a new feature or modifies an existing one.
       * **User Impact:** Will users need to change their code, configurations, or usage patterns?
       * **Build Impact:** Will this PR change how NuttX is built (new dependencies, build options, etc.)?
       * **Hardware Impact:**  Does this affect specific architectures, boards, or drivers?
       * **Documentation:**  Does this PR require documentation updates? If so, have you included them?
       * **Security/Compatibility:**  Analyze potential security risks and backward/forward compatibility issues.
   
   **Testing:**
   
   * **No Information:**  You haven't provided any information about your testing environment or the results.
   * **Details Required:** Include:
       * **Build Host OS:** (e.g., Ubuntu 20.04, macOS 13.0)
       * **Compiler:** (e.g., GCC 11.2, Clang 14.0)
       * **Target Architecture and Board:**  (e.g., ARM Cortex-M4, STM32F4 Discovery board)
       * **Testing Logs:** Provide relevant snippets from your testing logs demonstrating the changes' effects.
   
   **Example of an Improved Summary:**
   
   "This PR improves the PCI Express Endpoint Framework (EPF) in NuttX by [briefly explain the main goal, e.g., "optimizing memory management and simplifying device initialization"].  To achieve this, the PR introduces private data structures for EPF devices and controllers, uses a node-based linking mechanism for efficient resource management, and implements virtual memory for EPC memory regions.  This change is expected to [mention expected benefits, e.g., "reduce memory footprint and improve performance for PCI Express devices."] This PR addresses issue # [insert issue number]." 
   
   **Remember:** A good PR description is crucial for reviewers to understand your changes and ensure the quality of the NuttX codebase. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org