You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/07 17:33:56 UTC

[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #378: [YUNIKORN-593]Optimize the UT for ListApplications

craigcondit commented on pull request #378:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/378#issuecomment-1060944664


   > hi @HuangTing-Yao thanks for the PR, it's much clearer. Could you please check why the code coverage drops? That shouldn't happen, we should either see some increase or at least stay unchanged.
   
   @yangwwei and @HuangTing-Yao, it looks like the number of lines in the project decreased by 1, as did the lines covered (which is expected). I don't think this is a problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org