[jira] [Resolved] (SOLR-8032) unhandled exceptions

["Munendra S N (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Munendra S N resolved SOLR-8032.
--------------------------------
    Resolution: Not A Problem

Based on above comment resolving this

> unhandled exceptions
> --------------------
>
>                 Key: SOLR-8032
>                 URL: https://issues.apache.org/jira/browse/SOLR-8032
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0, 5.1
>            Reporter: songwanging
>            Priority: Minor
>
> In method close() of class RecoveryStrategy (solr\core\src\java\org\apache\solr\cloud\RecoveryStrategy.java)
> The catch block catch (NullPointerException e) performs no actions to handle its expected exception, which makes itself useless. 
> To fix this bug, we should add more code into the catch block to handle this exception.
> public void close() {
>     close = true;
>     try {
>       prevSendPreRecoveryHttpUriRequest.abort();
>     } catch (NullPointerException e) {
>       // okay
>     }
>    ...
>   }
> ==========
> In method startLeaderInitiatedRecoveryOnReplicas() of class ElectionContext (\solr\core\src\java\org\apache\solr\cloud\ElectionContext.java)
> The catch block catch (NoNodeException e) performs no actions to handle its expected exception, which makes itself useless. 
> To fix this bug, we should add more code into the catch block to handle this exception.
>  try {
>         replicas = zkClient.getChildren(znodePath, null, false);
>       } catch (NoNodeException nne) {
>         // this can be ignored
>       }



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org