You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 04:06:07 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1001: feat: change proxy target to localhost when test
LiteSun opened a new pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
As title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742336043
> CI failed
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#discussion_r539939593
##########
File path: web/config/proxy.ts
##########
@@ -14,11 +14,18 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+const serveUrlMap = {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742226272
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=h1) Report
> Merging [#1001](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=desc) (a1be099) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffcecfa7909b6a8b6a869fdd63b0e0542aa74bb5?el=desc) (ffcecfa) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1001 +/- ##
=======================================
Coverage 44.04% 44.04%
=======================================
Files 18 18
Lines 1310 1310
=======================================
Hits 577 577
Misses 642 642
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=footer). Last update [ffcecfa...a1be099](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#discussion_r539871034
##########
File path: web/config/proxy.ts
##########
@@ -14,11 +14,18 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+const serveUrlMap = {
Review comment:
serverURLXX?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742226272
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=h1) Report
> Merging [#1001](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=desc) (7ea0681) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffcecfa7909b6a8b6a869fdd63b0e0542aa74bb5?el=desc) (ffcecfa) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1001 +/- ##
=======================================
Coverage 44.04% 44.04%
=======================================
Files 18 18
Lines 1310 1310
=======================================
Hits 577 577
Misses 642 642
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=footer). Last update [ffcecfa...7ea0681](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742285963
CI failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742336478
> > CI failed
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun removed a comment on pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
LiteSun removed a comment on pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742336043
> CI failed
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742394759
cc @idbeta
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#discussion_r539880485
##########
File path: web/config/proxy.ts
##########
@@ -14,11 +14,18 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+const serveUrlMap = {
Review comment:
> serverURLXX?
refer to https://pro.ant.design/blog/proxy-cn#%E9%AB%98%E7%BA%A7%E7%94%A8%E6%B3%95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on pull request #1001: feat: change proxy target to localhost when test
Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #1001:
URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742424878
> cc @idbeta
Thanks for inform
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org