You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:54:31 UTC
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1244: Allow ExpireSnapshots to run without Deleting Files
aokolnychyi commented on a change in pull request #1244:
URL: https://github.com/apache/iceberg/pull/1244#discussion_r461721527
##########
File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java
##########
@@ -97,4 +97,16 @@
* @return this for method chaining
*/
ExpireSnapshots executeWith(ExecutorService executorService);
+
+ /**
+ * Allows expiration of snapshots without any cleanup of underlying manifest or data files.
+ * <p>
+ * Allows control in removing data and manifest files which may be more efficiently removed using
+ * a distributed framework through the actions API.
+ * <p>
Review comment:
nit: is this deliberately?
##########
File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java
##########
@@ -97,4 +97,16 @@
* @return this for method chaining
*/
ExpireSnapshots executeWith(ExecutorService executorService);
+
+ /**
+ * Allows expiration of snapshots without any cleanup of underlying manifest or data files.
+ * <p>
+ * Allows control in removing data and manifest files which may be more efficiently removed using
+ * a distributed framework through the actions API.
+ * <p>
Review comment:
nit: is this added deliberately?
##########
File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java
##########
@@ -97,4 +97,16 @@
* @return this for method chaining
*/
ExpireSnapshots executeWith(ExecutorService executorService);
+
+ /**
+ * Allows expiration of snapshots without any cleanup of underlying manifest or data files.
+ * <p>
+ * Allows control in removing data and manifest files which may be more efficiently removed using
+ * a distributed framework through the actions API.
+ * <p>
Review comment:
I mean an extra `<p>` at the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org