[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #292: [FLINK-28385] Change the validator to return an error if the Jar URI is an empty string

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #292:
URL: https://github.com/apache/flink-kubernetes-operator/pull/292#discussion_r913443188


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -178,7 +178,7 @@ private Optional<String> validateJobSpec(
             return Optional.empty();
         }
 
-        if (job.getJarURI() == null) {
+        if (job.getJarURI() == null || job.getJarURI().equals("")) {

Review Comment:
   This condition in this `if` check could be replaced by `StringUtils.isEmpty(job.getJarURI())`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org