You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/27 03:32:44 UTC
[GitHub] [incubator-seatunnel] Carl-Zhou-CN opened a new pull request, #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Carl-Zhou-CN opened a new pull request, #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
#2809
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r980770134
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
description = "check config")
private boolean checkConfig = false;
+ @Parameter(names = {"-n", "--name"},
Review Comment:
Please add the new parameter to the document https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/command/usage.mdx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r981036433
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
description = "check config")
private boolean checkConfig = false;
+ @Parameter(names = {"-n", "--name"},
Review Comment:
> >
>
> Can we add V2 starter in this doc https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/command/usage.mdx ?
If it's like EricJoy2048 says, I can try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r981020019
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
description = "check config")
private boolean checkConfig = false;
+ @Parameter(names = {"-n", "--name"},
Review Comment:
in fact, `connectot-v2` it's not much different from v1, it's just the scripts and jars that are started. Are you willing to submit documents in this regard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r981051946
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
description = "check config")
private boolean checkConfig = false;
+ @Parameter(names = {"-n", "--name"},
Review Comment:
if you have any question, you can ping me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r980993909
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
description = "check config")
private boolean checkConfig = false;
+ @Parameter(names = {"-n", "--name"},
Review Comment:
>
Can we add V2 starter in this doc https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/command/usage.mdx ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#issuecomment-1263349943
@EricJoy2048 I don't seem to have added or changed any dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#issuecomment-1275647033
@EricJoy2048 @CalvinKirs Please help review again, there are some conflicts in merge's new code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r980771112
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
description = "check config")
private boolean checkConfig = false;
+ @Parameter(names = {"-n", "--name"},
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#issuecomment-1263355849
> @EricJoy2048 I don't seem to have added or changed any dependencies
Because the `st-engine` branch merged to `dev` and the licenses have some problems. So please wait the pr https://github.com/apache/incubator-seatunnel/pull/2957 merged. And then I will rerun the ci of your pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#issuecomment-1258928979
spark ${SPARK_HOME}/bin/spark-submit --class "org.apache.seatunnel.core.starter.spark.SeatunnelSpark" --name "test1" --master "local[4]" --deploy-mode "client" --conf "spark.executor.memory=1g" --conf "spark.streaming.batchDuration=5" --conf "spark.executor.cores=1" --conf "job.name=SeaTunnel" --conf "spark.executor.instances=2" /data/seatunnel-2.1.3/lib/seatunnel-spark-starter.jar -n test1 --master local[4] --deploy-mode client --config ./config/spark.streaming.conf.template
flink ${FLINK_HOME}/bin/flink run -c org.apache.seatunnel.core.starter.flink.SeatunnelFlink /data/seatunnel-2.1.3/lib/seatunnel-flink-starter.jar --config ./config/flink.streaming.conf.template -Dpipeline.name=test
Env takes precedence over the command line,job.name is used to set the application name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#issuecomment-1272208874
@EricJoy2048 Please help me run the ci again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#issuecomment-1258923468
#2809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r980776794
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
description = "check config")
private boolean checkConfig = false;
+ @Parameter(names = {"-n", "--name"},
Review Comment:
@EricJoy2048 Currently, this parameter is only supported for V2. Is there a special document for V2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r980994127
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
description = "check config")
private boolean checkConfig = false;
+ @Parameter(names = {"-n", "--name"},
Review Comment:
> >
>
> Can we add V2 starter in this doc https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/command/usage.mdx ? @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org