You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2024/01/23 00:59:21 UTC
[PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Mryange opened a new pull request, #30248:
URL: https://github.com/apache/doris/pull/30248
## Proposed changes
[Issue Number: close #xxx](https://github.com/apache/doris/issues/30229)
Error Reason:
In the expression, time_to_sec(timediff('2024-01-22', '2024-01-15')), the two strings '2024-01-22' and '2024-01-15' are first cast to datetime types. Due to the absence of the timev2 type in the input parameters of the new optimizer for the time_to_sec function, it falls back to the old optimizer. At this point, the signature of timediff is name = "timediff", argTypes = { "DATETIME", "DATETIME" }, returnType = "TIMEV2"). This signature triggers constant folding, but the constant folding mechanism is outdated and hasn't been updated in subsequent releases. As a result, an error occurs.
In contrast, time_to_sec(timediff(to_date('2024-01-22'), to_date('2024-01-15'))), due to the presence of an additional function, does not trigger the constant folding error.
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905301654
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1911289096
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905104205
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905163646
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905335720
<details>
<summary>TPC-DS: <b>Total hot run time: 176600 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 478377275833f276f3f64e8ef94564ccd70022c6, data reload: false
query1 924 335 330 330
query2 6579 1974 1907 1907
query3 6705 196 196 196
query4 32038 22208 22213 22208
query5 4474 370 426 370
query6 249 166 153 153
query7 4600 260 260 260
query8 246 173 172 172
query9 8286 2547 2524 2524
query10 425 222 225 222
query11 17056 15634 15594 15594
query12 127 68 66 66
query13 1675 376 382 376
query14 10474 7030 7040 7030
query15 212 173 182 173
query16 5791 268 244 244
query17 952 470 476 470
query18 1797 264 246 246
query19 175 127 134 127
query20 67 68 68 68
query21 183 130 141 130
query22 4983 4710 4653 4653
query23 31230 30800 30793 30793
query24 11244 2740 2758 2740
query25 551 318 298 298
query26 886 143 143 143
query27 2868 292 288 288
query28 6294 1833 1833 1833
query29 938 621 630 621
query30 275 148 135 135
query31 944 746 746 746
query32 79 50 50 50
query33 594 214 214 214
query34 883 444 453 444
query35 901 776 763 763
query36 1340 1260 1146 1146
query37 89 61 60 60
query38 3385 3247 3254 3247
query39 1303 1295 1267 1267
query40 194 83 81 81
query41 50 36 33 33
query42 89 83 83 83
query43 508 468 456 456
query44 1034 684 687 684
query45 191 178 177 177
query46 1053 654 636 636
query47 1580 1499 1542 1499
query48 405 312 305 305
query49 1083 314 274 274
query50 671 308 299 299
query51 5322 5284 5269 5269
query52 88 88 73 73
query53 326 248 266 248
query54 242 185 176 176
query55 79 78 75 75
query56 176 170 158 158
query57 995 957 915 915
query58 176 161 158 158
query59 2967 2803 2551 2551
query60 203 179 179 179
query61 79 80 80 80
query62 615 373 355 355
query63 282 267 257 257
query64 4275 1769 1763 1763
query65 3336 3267 3207 3207
query66 1208 315 313 313
query67 15565 15307 15291 15291
query68 10938 531 506 506
query69 599 301 295 295
query70 1742 1576 1529 1529
query71 551 209 209 209
query72 5051 2858 2838 2838
query73 2122 314 317 314
query74 7151 6405 6478 6405
query75 4930 2291 2275 2275
query76 6795 987 993 987
query77 668 224 235 224
query78 9113 8762 8627 8627
query79 1015 493 491 491
query80 537 316 308 308
query81 473 206 201 201
query82 183 85 81 81
query83 142 116 119 116
query84 277 67 68 67
query85 1062 328 333 328
query86 392 387 383 383
query87 3511 3368 3344 3344
query88 2838 2191 2173 2173
query89 417 354 346 346
query90 1999 186 180 180
query91 153 124 133 124
query92 54 46 45 45
query93 975 434 444 434
query94 1157 166 152 152
query95 494 456 454 454
query96 619 319 312 312
query97 4304 4105 4190 4105
query98 202 201 180 180
query99 1090 665 714 665
Total cold run time: 286168 ms
Total hot run time: 176600 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905146409
<details>
<summary>ClickBench: <b>Total hot run time: 30.41 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7992c34099130f0e4f19e1cc9fff3376a42e62d0, data reload: false
query1 0.03 0.02 0.02
query2 0.06 0.03 0.02
query3 0.23 0.05 0.04
query4 1.71 0.07 0.07
query5 0.54 0.53 0.53
query6 1.26 0.63 0.63
query7 0.02 0.02 0.01
query8 0.03 0.03 0.03
query9 0.54 0.50 0.50
query10 0.56 0.56 0.56
query11 0.12 0.09 0.08
query12 0.11 0.09 0.09
query13 0.62 0.62 0.61
query14 0.79 0.79 0.81
query15 0.79 0.78 0.77
query16 0.37 0.38 0.37
query17 1.04 1.01 1.01
query18 0.24 0.24 0.26
query19 1.81 1.77 1.83
query20 0.01 0.01 0.01
query21 15.43 0.57 0.54
query22 2.44 1.91 2.18
query23 17.41 0.80 0.70
query24 2.42 1.57 0.45
query25 0.42 0.19 0.11
query26 0.47 0.14 0.13
query27 0.06 0.06 0.05
query28 11.74 0.77 0.77
query29 12.51 3.20 3.25
query30 0.57 0.51 0.48
query31 2.78 0.35 0.36
query32 3.34 0.48 0.47
query33 3.17 3.24 3.26
query34 15.76 4.27 4.28
query35 4.32 4.31 4.26
query36 1.11 1.07 1.07
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.02 0.01
query40 0.16 0.14 0.13
query41 0.08 0.01 0.01
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 105.25 s
Total hot run time: 30.41 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905340126
<details>
<summary>ClickBench: <b>Total hot run time: 31.42 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 478377275833f276f3f64e8ef94564ccd70022c6, data reload: false
query1 0.04 0.03 0.02
query2 0.07 0.02 0.02
query3 0.22 0.05 0.06
query4 1.70 0.07 0.07
query5 0.54 0.52 0.52
query6 1.25 0.63 0.66
query7 0.02 0.01 0.01
query8 0.04 0.02 0.02
query9 0.56 0.49 0.48
query10 0.56 0.56 0.55
query11 0.12 0.08 0.08
query12 0.11 0.10 0.09
query13 0.61 0.62 0.61
query14 0.78 0.82 0.80
query15 0.78 0.77 0.77
query16 0.40 0.37 0.39
query17 1.02 1.00 1.02
query18 0.23 0.25 0.25
query19 1.88 1.78 1.78
query20 0.01 0.01 0.01
query21 15.42 0.58 0.56
query22 2.29 2.21 2.18
query23 17.47 0.90 0.78
query24 2.34 1.72 1.10
query25 0.38 0.21 0.12
query26 0.58 0.13 0.14
query27 0.07 0.05 0.05
query28 10.73 0.78 0.76
query29 12.53 3.21 3.16
query30 0.54 0.56 0.48
query31 2.78 0.35 0.35
query32 3.37 0.48 0.48
query33 3.20 3.25 3.27
query34 15.78 4.27 4.29
query35 4.33 4.29 4.29
query36 1.11 1.07 1.07
query37 0.06 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.01 0.01
query40 0.16 0.13 0.14
query41 0.08 0.01 0.01
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 104.27 s
Total hot run time: 31.42 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905342519
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 478377275833f276f3f64e8ef94564ccd70022c6 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 14.7 seconds inserted 10000000 Rows, about 680K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905326180
<details>
<summary>TPC-H: <b>Total hot run time: 39007 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 478377275833f276f3f64e8ef94564ccd70022c6, data reload: false
------ Round 1 ----------------------------------
q1 17666 5534 5244 5244
q2 2042 139 132 132
q3 10655 1192 1183 1183
q4 10217 766 781 766
q5 7785 3143 3118 3118
q6 204 120 120 120
q7 885 493 491 491
q8 9240 1907 1943 1907
q9 7274 6411 6365 6365
q10 8227 3094 3047 3047
q11 418 205 221 205
q12 356 185 193 185
q13 17993 3377 3351 3351
q14 238 225 212 212
q15 541 522 505 505
q16 447 383 383 383
q17 913 559 497 497
q18 7566 6953 6914 6914
q19 1560 1364 1402 1364
q20 604 300 286 286
q21 2785 2420 2422 2420
q22 347 312 323 312
Total cold run time: 107963 ms
Total hot run time: 39007 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5434 5327 5309 5309
q2 321 218 215 215
q3 3375 3448 3244 3244
q4 2084 2010 2092 2010
q5 5955 5850 5947 5850
q6 200 116 116 116
q7 2294 1915 1849 1849
q8 3239 3383 3396 3383
q9 8962 8979 8871 8871
q10 3883 3770 3817 3770
q11 567 468 453 453
q12 837 588 627 588
q13 16926 3169 3171 3169
q14 281 260 271 260
q15 551 496 512 496
q16 519 467 474 467
q17 2085 1840 1878 1840
q18 9426 17925 9604 9604
q19 22878 1632 1543 1543
q20 4620 1959 1927 1927
q21 14386 5317 5383 5317
q22 1003 541 578 541
Total cold run time: 109826 ms
Total hot run time: 60822 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905149785
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 7992c34099130f0e4f19e1cc9fff3376a42e62d0 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.6 seconds inserted 10000000 Rows, about 735K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905199990
run pipelinex_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905141008
<details>
<summary>TPC-DS: <b>Total hot run time: 177025 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7992c34099130f0e4f19e1cc9fff3376a42e62d0, data reload: false
query1 922 332 324 324
query2 6559 1891 2122 1891
query3 6699 201 202 201
query4 30717 22210 22115 22115
query5 4460 435 432 432
query6 237 162 162 162
query7 4605 273 272 272
query8 228 195 175 175
query9 8338 2570 2551 2551
query10 414 242 228 228
query11 16943 15665 15520 15520
query12 121 68 66 66
query13 1663 378 388 378
query14 10533 7069 6924 6924
query15 210 186 184 184
query16 5797 258 249 249
query17 946 481 471 471
query18 1786 253 251 251
query19 176 132 135 132
query20 74 74 72 72
query21 191 130 115 115
query22 4919 4768 4756 4756
query23 31701 30950 30853 30853
query24 11538 2863 2795 2795
query25 572 303 303 303
query26 1582 144 144 144
query27 3063 290 284 284
query28 7365 1841 1832 1832
query29 1436 628 611 611
query30 277 136 134 134
query31 966 754 738 738
query32 73 50 48 48
query33 700 210 210 210
query34 1094 461 461 461
query35 887 770 743 743
query36 1388 1327 1253 1253
query37 95 60 61 60
query38 3413 3211 3196 3196
query39 1304 1288 1257 1257
query40 207 85 82 82
query41 36 34 34 34
query42 93 81 84 81
query43 547 488 471 471
query44 1135 685 692 685
query45 195 181 174 174
query46 1050 651 658 651
query47 1667 1532 1562 1532
query48 403 317 323 317
query49 1127 289 279 279
query50 678 309 317 309
query51 5334 5184 5163 5163
query52 92 77 72 72
query53 327 265 250 250
query54 230 183 181 181
query55 86 74 73 73
query56 179 163 168 163
query57 1044 936 938 936
query58 188 164 165 164
query59 2837 2699 2666 2666
query60 213 182 188 182
query61 81 81 80 80
query62 615 354 359 354
query63 284 256 268 256
query64 4943 1772 1719 1719
query65 3339 3259 3265 3259
query66 1292 305 312 305
query67 15726 15382 15541 15382
query68 11542 540 533 533
query69 617 297 303 297
query70 1711 1519 1542 1519
query71 548 217 216 216
query72 5014 2821 2814 2814
query73 2053 310 315 310
query74 6987 6360 6389 6360
query75 4842 2333 2321 2321
query76 6755 983 1022 983
query77 654 231 234 231
query78 9047 8793 8657 8657
query79 1924 495 506 495
query80 592 324 319 319
query81 468 206 197 197
query82 200 81 83 81
query83 139 121 119 119
query84 272 69 67 67
query85 1109 338 328 328
query86 405 438 393 393
query87 3485 3349 3358 3349
query88 3153 2195 2189 2189
query89 444 352 368 352
query90 1980 187 182 182
query91 160 134 142 134
query92 51 47 46 46
query93 2659 427 452 427
query94 1244 159 160 159
query95 500 453 446 446
query96 614 321 313 313
query97 4277 4154 4141 4141
query98 212 187 191 187
query99 1033 649 724 649
Total cold run time: 292631 ms
Total hot run time: 177025 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1909356642
run pipelinex_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #30248:
URL: https://github.com/apache/doris/pull/30248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905112160
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905112879
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) fix error result in time_to_sec and timediff [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30248:
URL: https://github.com/apache/doris/pull/30248#issuecomment-1905131535
<details>
<summary>TPC-H: <b>Total hot run time: 38729 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7992c34099130f0e4f19e1cc9fff3376a42e62d0, data reload: false
------ Round 1 ----------------------------------
q1 17686 5272 5184 5184
q2 2031 139 131 131
q3 10755 1177 1166 1166
q4 10336 755 768 755
q5 7771 3126 3169 3126
q6 197 119 120 119
q7 837 484 477 477
q8 9223 1930 1964 1930
q9 7232 6379 6328 6328
q10 8172 3037 3086 3037
q11 422 206 213 206
q12 354 190 187 187
q13 17999 3354 3345 3345
q14 238 213 213 213
q15 540 503 509 503
q16 425 368 397 368
q17 922 542 525 525
q18 7514 6855 6784 6784
q19 1924 1329 1351 1329
q20 562 312 291 291
q21 2743 2438 2420 2420
q22 369 307 305 305
Total cold run time: 108252 ms
Total hot run time: 38729 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5477 5296 5221 5221
q2 326 216 209 209
q3 3338 3249 3232 3232
q4 2105 2055 1980 1980
q5 5894 5893 5744 5744
q6 202 116 119 116
q7 2359 1832 1953 1832
q8 3184 3357 3401 3357
q9 8907 8857 8794 8794
q10 3937 3814 3917 3814
q11 549 465 468 465
q12 809 638 623 623
q13 17431 3170 3206 3170
q14 286 272 259 259
q15 565 508 507 507
q16 506 473 478 473
q17 1924 1881 1828 1828
q18 9501 17706 9736 9736
q19 23599 1643 1570 1570
q20 4685 2012 2050 2012
q21 14961 5785 5707 5707
q22 1018 585 559 559
Total cold run time: 111563 ms
Total hot run time: 61208 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org