You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2014/04/09 20:18:25 UTC
svn commit: r1586064 - in
/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client:
HTable.java HTableInterface.java
Author: liyin
Date: Wed Apr 9 18:18:24 2014
New Revision: 1586064
URL: http://svn.apache.org/r1586064
Log:
[HBASE-10910] Make sure we do most optimal multiGets Revert
Author: adela
Summary:
This reverts commit d5d09c2b28b4f0bc3c33ebe8d7a92081f90fe89c.
Reverting because it breaks some unit tests and also breaks some expected behavior of get(List<Get>)
Test Plan: no need to test :)
Reviewers: daviddeng, fan, gauravm, manukranthk
Reviewed By: daviddeng
CC: hbase-eng@
Differential Revision: https://phabricator.fb.com/D1265457
Modified:
hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTable.java
hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTable.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTable.java?rev=1586064&r1=1586063&r2=1586064&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTable.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTable.java Wed Apr 9 18:18:24 2014
@@ -777,7 +777,7 @@ public class HTable implements HTableInt
@Override
public Result[] get(List<Get> gets) throws IOException {
- return batchGet(gets);
+ return this.getConnectionAndResetOperationContext().processBatchOfGets(gets, tableName, this.options);
}
/**
Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java?rev=1586064&r1=1586063&r2=1586064&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java Wed Apr 9 18:18:24 2014
@@ -82,26 +82,20 @@ public interface HTableInterface {
*/
Result get(Get get) throws IOException;
- /**
- * Extracts certain cells from the given rows, in batch. It does completely
- * the same thing as {@link #batchGet(List)}, so we are planning to get rid of
- * this one soon in favor of {@link #batchGet(List)}
+ /**
+ * Extracts certain cells from the given rows, in batch.
*
- * @param gets
- * The objects that specify what data to fetch and from which rows.
+ * @param gets The objects that specify what data to fetch and from which rows.
*
- * @return The data coming from the specified rows, if it exists. If the row
+ * @return The data coming from the specified rows, if it exists. If the row
* specified doesn't exist, the {@link Result} instance returned won't
- * contain any {@link KeyValue}, as indicated by
- * {@link Result#isEmpty()}. If there are any failures even after
- * retries, there will be a null in the results array for those Gets,
- * AND an exception will be thrown.
- * @throws IOException
- * if a remote or network exception occurs.
+ * contain any {@link KeyValue}, as indicated by {@link Result#isEmpty()}.
+ * If there are any failures even after retries, there will be a null in
+ * the results array for those Gets, AND an exception will be thrown.
+ * @throws IOException if a remote or network exception occurs.
*
* @since 0.20.0
*/
- @Deprecated
public Result[] get(List<Get> gets) throws IOException;
/**