You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "OlegChuev (via GitHub)" <gi...@apache.org> on 2023/11/28 09:40:45 UTC
[PR] UI: Removed redundant IP Address Column [cloudstack]
OlegChuev opened a new pull request, #8275:
URL: https://github.com/apache/cloudstack/pull/8275
### Description
This PR removes redundant IP Address column
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [X] Enhancement (improves an existing feature and functionality)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [X] Minor
#### Bug Severity
- [X] Trivial
### Screenshots (if appropriate):
Before fix:
<img width="854" alt="Screenshot 2023-11-27 at 19 01 34" src="https://github.com/apache/cloudstack/assets/91337563/f231e9fb-1da7-47d4-9d70-38bf4bdab1ac">
After fix:
<img width="862" alt="Screenshot 2023-11-28 at 11 34 52" src="https://github.com/apache/cloudstack/assets/91337563/d475f10d-eb1e-48c5-94ba-52f1dba6a12d">
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1829768180
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1829523607
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8275?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`88ff77d`)](https://app.codecov.io/gh/apache/cloudstack/commit/88ff77dae10e095afc10731bbef50668cb1df19c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 12.93% compared to head [(`a67d801`)](https://app.codecov.io/gh/apache/cloudstack/pull/8275?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 4.49%.
> Report is 537 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8275 +/- ##
============================================
- Coverage 12.93% 4.49% -8.45%
============================================
Files 2715 354 -2361
Lines 256107 27935 -228172
Branches 39938 4885 -35053
============================================
- Hits 33139 1255 -31884
+ Misses 218808 26542 -192266
+ Partials 4160 138 -4022
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.49% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8275?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1835654562
merging based on 2 approvals and manual testing result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1831821861
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "OlegChuev (via GitHub)" <gi...@apache.org>.
OlegChuev commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1831651570
> should this go on the 4.18 branch?
yep, sorry, I missed it. I'll change the target branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1829515957
code looks good, but I am not sure if an operator wouldn´t want to see the ip during configuration of the pf rules. If it is not available though , ... It seems strange and may be a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1829768496
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1829810239
@weizhouapache @OlegChuev should this go on the 4.18 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1829585107
> code looks good, but I am not sure if an operator wouldn´t want to see the ip during configuration of the pf rules. If it is not available though , ... It seems strange and may be a bug.
the IP is displayed when a VM is choosed.
now the view is almost same as the view when adding load balancing rules (IPs are not displayed in the list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1829790309
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8275 (QA-JID-235)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Removed redundant IP Address Column [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8275:
URL: https://github.com/apache/cloudstack/pull/8275#issuecomment-1831819955
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org