You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/08/14 21:18:10 UTC
[GitHub] jihoonson commented on issue #6173: Composite request logger
doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies
jihoonson commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies
URL: https://github.com/apache/incubator-druid/pull/6173#issuecomment-413019439
Hi @samarthjain, thank you for the PR. Would you add some more details about this change to the PR description? It's not intuitive to me because it looks that any class annotated with `LifecycleStart` and `LifecycleStop` should be started/stopped automatically without this change if they are properly added to the `Lifecycle`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org