You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "shuwenwei (via GitHub)" <gi...@apache.org> on 2024/09/09 08:57:17 UTC
[PR] Fix compaction device info cache [iotdb]
shuwenwei opened a new pull request, #13453:
URL: https://github.com/apache/iotdb/pull/13453
## Description
Fix compaction device info cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compaction device info cache [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #13453:
URL: https://github.com/apache/iotdb/pull/13453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compaction device info cache [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 commented on code in PR #13453:
URL: https://github.com/apache/iotdb/pull/13453#discussion_r1751142994
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/utils/TsFileResourceCandidate.java:
##########
@@ -72,6 +72,7 @@ public boolean unsealed() {
}
private void prepareDeviceInfos() throws IOException {
+ boolean canCacheDeviceInfo = resource.getStatus() != TsFileResourceStatus.UNCLOSED;
if (deviceInfoMap == null && compactionScheduleContext != null) {
Review Comment:
Is it even necessary to calculate DeviceInfo for an unclosed file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compaction device info cache [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 commented on code in PR #13453:
URL: https://github.com/apache/iotdb/pull/13453#discussion_r1751142994
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/utils/TsFileResourceCandidate.java:
##########
@@ -72,6 +72,7 @@ public boolean unsealed() {
}
private void prepareDeviceInfos() throws IOException {
+ boolean canCacheDeviceInfo = resource.getStatus() != TsFileResourceStatus.UNCLOSED;
if (deviceInfoMap == null && compactionScheduleContext != null) {
Review Comment:
Is it even necessary to calculate DeviceInfo for an unclosed file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org