You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Hiram Chirino (JIRA)" <ji...@apache.org> on 2008/10/09 16:29:54 UTC

[jira] Created: (AMQ-1972) Pluggable exception handler for JDBC DefaultDatabaseLocker

Pluggable exception handler for JDBC DefaultDatabaseLocker
----------------------------------------------------------

                 Key: AMQ-1972
                 URL: https://issues.apache.org/activemq/browse/AMQ-1972
             Project: ActiveMQ
          Issue Type: Improvement
            Reporter: Hiram Chirino
            Assignee: Hiram Chirino
             Fix For: 5.3.0


Sometimes folks want to use a custom error handler when using a custom database locking strategy.. that way they can inspect the error message for known SQL error codes and such.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (AMQ-1972) Pluggable exception handler for JDBC DefaultDatabaseLocker

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved AMQ-1972.
--------------------------------

    Resolution: Fixed

Implemented in rev 703172

> Pluggable exception handler for JDBC DefaultDatabaseLocker
> ----------------------------------------------------------
>
>                 Key: AMQ-1972
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1972
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Hiram Chirino
>            Assignee: Hiram Chirino
>             Fix For: 5.3.0
>
>
> Sometimes folks want to use a custom error handler when using a custom database locking strategy.. that way they can inspect the error message for known SQL error codes and such.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (AMQ-1972) Pluggable exception handler for JDBC DefaultDatabaseLocker

Posted by "Bruce Snyder (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Snyder updated AMQ-1972:
------------------------------

    Fix Version/s:     (was: 5.2.0)
                   5.3.0

> Pluggable exception handler for JDBC DefaultDatabaseLocker
> ----------------------------------------------------------
>
>                 Key: AMQ-1972
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1972
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Hiram Chirino
>            Assignee: Bruce Snyder
>             Fix For: 5.3.0
>
>
> Sometimes folks want to use a custom error handler when using a custom database locking strategy.. that way they can inspect the error message for known SQL error codes and such.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (AMQ-1972) Pluggable exception handler for JDBC DefaultDatabaseLocker

Posted by "Bruce Snyder (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Snyder reassigned AMQ-1972:
---------------------------------

    Assignee: Bruce Snyder  (was: Hiram Chirino)

> Pluggable exception handler for JDBC DefaultDatabaseLocker
> ----------------------------------------------------------
>
>                 Key: AMQ-1972
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1972
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Hiram Chirino
>            Assignee: Bruce Snyder
>             Fix For: 5.2.0
>
>
> Sometimes folks want to use a custom error handler when using a custom database locking strategy.. that way they can inspect the error message for known SQL error codes and such.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Reopened: (AMQ-1972) Pluggable exception handler for JDBC DefaultDatabaseLocker

Posted by "Bruce Snyder (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Snyder reopened AMQ-1972:
-------------------------------


The changes for this issue caused the {{DefaultDatabaseLocker}} to leak connections. Because the call to close the JDBC connection was removed and a default {{Handler}} implementation (that closes connections) was not provided, the {{DefaultDatabaseLocker.start()}} method now leaks a connection upon every iteration of the while loop. We need to provide a default {{Handler}} impl to at least close the JDBC connection instead of just the simple log statement that's there. 

> Pluggable exception handler for JDBC DefaultDatabaseLocker
> ----------------------------------------------------------
>
>                 Key: AMQ-1972
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1972
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Hiram Chirino
>            Assignee: Hiram Chirino
>             Fix For: 5.2.0
>
>
> Sometimes folks want to use a custom error handler when using a custom database locking strategy.. that way they can inspect the error message for known SQL error codes and such.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (AMQ-1972) Pluggable exception handler for JDBC DefaultDatabaseLocker

Posted by "Bruce Snyder (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Snyder resolved AMQ-1972.
-------------------------------

    Resolution: Fixed

> Pluggable exception handler for JDBC DefaultDatabaseLocker
> ----------------------------------------------------------
>
>                 Key: AMQ-1972
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1972
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Hiram Chirino
>            Assignee: Bruce Snyder
>             Fix For: 5.3.0
>
>         Attachments: AMQ-1972.patch.txt
>
>
> Sometimes folks want to use a custom error handler when using a custom database locking strategy.. that way they can inspect the error message for known SQL error codes and such.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (AMQ-1972) Pluggable exception handler for JDBC DefaultDatabaseLocker

Posted by "Bruce Snyder (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54003#action_54003 ] 

Bruce Snyder commented on AMQ-1972:
-----------------------------------

Fixed in [revision 811069|http://svn.apache.org/viewvc?view=rev&revision=811069]. 

> Pluggable exception handler for JDBC DefaultDatabaseLocker
> ----------------------------------------------------------
>
>                 Key: AMQ-1972
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1972
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Hiram Chirino
>            Assignee: Bruce Snyder
>             Fix For: 5.3.0
>
>         Attachments: AMQ-1972.patch.txt
>
>
> Sometimes folks want to use a custom error handler when using a custom database locking strategy.. that way they can inspect the error message for known SQL error codes and such.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (AMQ-1972) Pluggable exception handler for JDBC DefaultDatabaseLocker

Posted by "Bruce Snyder (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Snyder updated AMQ-1972:
------------------------------

    Attachment: AMQ-1972.patch.txt

Actually, after looking closer, the problem is not the lack of a default {{Hander}} impl. The problem is due to the fact that the finally clause where the connection is closed was removed. I've added a try/finally clause back in specifically to close the connection. See the attached patch. 

> Pluggable exception handler for JDBC DefaultDatabaseLocker
> ----------------------------------------------------------
>
>                 Key: AMQ-1972
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1972
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Hiram Chirino
>            Assignee: Bruce Snyder
>             Fix For: 5.3.0
>
>         Attachments: AMQ-1972.patch.txt
>
>
> Sometimes folks want to use a custom error handler when using a custom database locking strategy.. that way they can inspect the error message for known SQL error codes and such.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.