You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/26 09:28:05 UTC
[GitHub] [apisix-website] liuxiran opened a new pull request #518: fix: remove show case in homepage
liuxiran opened a new pull request #518:
URL: https://github.com/apache/apisix-website/pull/518
Changes:
Remove showcase in homepage, and we should redesign this part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#issuecomment-906244777
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: af88addf334498f93786198dca60e20044b3affc
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/61275e94491bdc00076589d6](https://app.netlify.com/sites/apisix/deploys/61275e94491bdc00076589d6?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#discussion_r696478673
##########
File path: website/src/pages/index.js
##########
@@ -113,59 +113,6 @@ const LearnHow = () => (
</div>
);
-const Showcase = () => {
- const { siteConfig } = useDocusaurusContext();
- if (!(siteConfig.customFields.showcases || []).length) {
- return null;
- }
- const showcases = siteConfig.customFields.showcases.map((user) => (
Review comment:
`siteConfig.customFields.showcases` Do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#issuecomment-906881044
this pr will be ready when our showcase page online
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#issuecomment-915809250
since #547 has been merged, this pr marked ready now, please have a look when you have time, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran merged pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
liuxiran merged pull request #518:
URL: https://github.com/apache/apisix-website/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran edited a comment on pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#issuecomment-915809250
since #547 has been merged, this pr marked ready now, please have a look when you have time, thanks
also cc @1502shivam-singh @Baoyuantop @guoqqqi @iamayushdas to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on a change in pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#discussion_r700421442
##########
File path: website/src/pages/index.js
##########
@@ -113,59 +113,6 @@ const LearnHow = () => (
</div>
);
-const Showcase = () => {
- const { siteConfig } = useDocusaurusContext();
- if (!(siteConfig.customFields.showcases || []).length) {
- return null;
- }
- const showcases = siteConfig.customFields.showcases.map((user) => (
Review comment:
yes, we will reuse it in our new show case page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#issuecomment-906457783
Hey @liuxiran , checkout #519 I shared some perspective from my side on this. Good step to take I suppose 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#issuecomment-910499065
this can be merged after https://github.com/apache/apisix-website/pull/547 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #518: fix: remove show case in homepage
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #518:
URL: https://github.com/apache/apisix-website/pull/518#issuecomment-906244777
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: af88addf334498f93786198dca60e20044b3affc
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/61275e94491bdc00076589d6](https://app.netlify.com/sites/apisix/deploys/61275e94491bdc00076589d6?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-518--apisix.netlify.app](https://deploy-preview-518--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org