You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lsyldliu (via GitHub)" <gi...@apache.org> on 2025/01/10 08:15:07 UTC

[PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

lsyldliu opened a new pull request, #25947:
URL: https://github.com/apache/flink/pull/25947

   
   ## What is the purpose of the change
   
   *Remove deprecated interface CatalogLock*
   
   
   ## Brief change log
     - *Remove deprecated interface CatalogLock*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2585731606

   If there is no more input, I will merge it tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2582519779

   > I have raised https://issues.apache.org/jira/browse/FLINK-37097 to track the removal of the Hive connector from core flink,
   
   Good job, assign to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2582466083

   I see in HiveDynamicTableFactory that there are references to RequireCatalogLock


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2586028365

   Merging it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu merged PR #25947:
URL: https://github.com/apache/flink/pull/25947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "xuyangzhong (via GitHub)" <gi...@apache.org>.
xuyangzhong commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2582796136

   @davidradl FYI we can ignore all classes in hive connector module in flink repo. You can refer more here https://issues.apache.org/jira/browse/FLINK-37094


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2582943114

   @snuyanzin fyi  This PR is removing a class that the Hive connector depends on. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2582517352

   > I just checked the external Hive connector and that refers to the class we are removing. I think we need a plan for the Hive connector before removing it from core Flink
   
   We can remove the related code when we bump flink version to 2.0 in hive connector.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2582494988

   > I see in HiveDynamicTableFactory that there are references to RequireCatalogLock
   
   The hive module has been externalized, we should focus on the code in this repository: https://github.com/apache/flink-connector-hive, the hive module in flink repository will be deleted, and now it has been removed from the pom file and no longer compiles and runs ci.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2582518192

   I have raised https://issues.apache.org/jira/browse/FLINK-37097 to track the removal of the Hive connector from core flink, 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25947:
URL: https://github.com/apache/flink/pull/25947#issuecomment-2582054899

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0557987216d7d26709023fd6cfc2379ec9f92eae",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0557987216d7d26709023fd6cfc2379ec9f92eae",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0557987216d7d26709023fd6cfc2379ec9f92eae UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org