You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by reiabreu <gi...@git.apache.org> on 2018/04/03 18:07:43 UTC

[GitHub] storm pull request #2620: STORM-2994: KafkaSpout doesn't commit offsets for ...

GitHub user reiabreu opened a pull request:

    https://github.com/apache/storm/pull/2620

    STORM-2994: KafkaSpout doesn't commit offsets for null tuples

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reiabreu/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2620
    
----
commit d8a37d8f4e1e4a5b42255d01f9743eed2a99424e
Author: Rui Abreu <ru...@...>
Date:   2018-04-03T09:21:05Z

    STORM-2994: KafkaSpout consumes messages but doesn't commit offsets

----


---

[GitHub] storm issue #2620: STORM-2994: KafkaSpout doesn't commit offsets for null tu...

Posted by reiabreu <gi...@git.apache.org>.
Github user reiabreu commented on the issue:

    https://github.com/apache/storm/pull/2620
  
    Yeah, going through the Travis logs it does seem they are unstable.
    Thank you for your help. Much appreciated.


---

[GitHub] storm pull request #2620: STORM-2994: KafkaSpout doesn't commit offsets for ...

Posted by reiabreu <gi...@git.apache.org>.
GitHub user reiabreu reopened a pull request:

    https://github.com/apache/storm/pull/2620

    STORM-2994: KafkaSpout doesn't commit offsets for null tuples

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reiabreu/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2620
    
----
commit d8a37d8f4e1e4a5b42255d01f9743eed2a99424e
Author: Rui Abreu <ru...@...>
Date:   2018-04-03T09:21:05Z

    STORM-2994: KafkaSpout consumes messages but doesn't commit offsets

----


---

[GitHub] storm pull request #2620: STORM-2994: KafkaSpout doesn't commit offsets for ...

Posted by reiabreu <gi...@git.apache.org>.
Github user reiabreu closed the pull request at:

    https://github.com/apache/storm/pull/2620


---

[GitHub] storm issue #2620: STORM-2994: KafkaSpout doesn't commit offsets for null tu...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2620
  
    Sorry, the tests sadly are very unstable on travis on the 1.x branch. Ran the storm-kafka-client tests locally and verified that they work on Java 7. 


---

[GitHub] storm pull request #2620: STORM-2994: KafkaSpout doesn't commit offsets for ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2620


---