You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2013/12/31 11:28:20 UTC
Review Request 16528: Scheduler home page new using AngularJS and UI client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
Thanks,
Suman Karumuri
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 2, 2014, 10:57 p.m., Bill Farner wrote:
> > src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html, line 23
> > <https://reviews.apache.org/r/16528/diff/1/?file=407232#file407232line23>
> >
> > remove? seems superfluous
>
> Suman Karumuri wrote:
> For performance reasons and for progressive rendering, JS scripts are always added to the end of the html file.
>
> Some people use this convention to signal the end of HTML in a file. Beyond this point only scripts and other interactive stuff should be included. Some scripts only work when they are included at the right places in the html file. A tag like this also ensures that the scripts below are well behaved. Following the convention here, so would like to keep it.
>
> Bill Farner wrote:
> I was actually referring to the presence of "<!-- Scripts -->" as being superfluous, not the placement of the script tags. Convention set in this file and conventional wisdom seem to be good enough to make this extra tag/line unnecessary.
Oh. Done. Removed.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31080
-----------------------------------------------------------
On Jan. 3, 2014, 10:34 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2014, 10:34 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
> src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 2, 2014, 10:57 p.m., Bill Farner wrote:
> > src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java, line 182
> > <https://reviews.apache.org/r/16528/diff/1/?file=407229#file407229line182>
> >
> > The selective use of camel-case is slightly jarring. Is there a convention you're following?
api_types.js and ReadOnlyScheduler.js are files generated by the thrift compiler. The name of the later file is the name of the service. So, I don't have much control over their naming.
Similarly Smart-Table.js, is installed from a bower package.
I am exposing all the files with names in camel case though.
> On Jan. 2, 2014, 10:57 p.m., Bill Farner wrote:
> > src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html, line 23
> > <https://reviews.apache.org/r/16528/diff/1/?file=407232#file407232line23>
> >
> > remove? seems superfluous
For performance reasons and for progressive rendering, JS scripts are always added to the end of the html file.
Some people use this convention to signal the end of HTML in a file. Beyond this point only scripts and other interactive stuff should be included. Some scripts only work when they are included at the right places in the html file. A tag like this also ensures that the scripts below are well behaved. Following the convention here, so would like to keep it.
> On Jan. 2, 2014, 10:57 p.m., Bill Farner wrote:
> > src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java, line 92
> > <https://reviews.apache.org/r/16528/diff/1/?file=407229#file407229line92>
> >
> > Shouldn't the newly-added page be replacing this?
I was waiting on you to make that call. Changed it now.
> On Jan. 2, 2014, 10:57 p.m., Bill Farner wrote:
> > build.gradle, line 218
> > <https://reviews.apache.org/r/16528/diff/1/?file=407228#file407228line218>
> >
> > build is faster and code is more compact if you just pass these args in the invocation above
done.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31080
-----------------------------------------------------------
On Jan. 2, 2014, 10:48 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2014, 10:48 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
> src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 2, 2014, 10:57 p.m., Bill Farner wrote:
> > src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html, line 23
> > <https://reviews.apache.org/r/16528/diff/1/?file=407232#file407232line23>
> >
> > remove? seems superfluous
>
> Suman Karumuri wrote:
> For performance reasons and for progressive rendering, JS scripts are always added to the end of the html file.
>
> Some people use this convention to signal the end of HTML in a file. Beyond this point only scripts and other interactive stuff should be included. Some scripts only work when they are included at the right places in the html file. A tag like this also ensures that the scripts below are well behaved. Following the convention here, so would like to keep it.
I was actually referring to the presence of "<!-- Scripts -->" as being superfluous, not the placement of the script tags. Convention set in this file and conventional wisdom seem to be good enough to make this extra tag/line unnecessary.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31080
-----------------------------------------------------------
On Jan. 3, 2014, 10:34 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2014, 10:34 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
> src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31080
-----------------------------------------------------------
build.gradle
<https://reviews.apache.org/r/16528/#comment59416>
build is faster and code is more compact if you just pass these args in the invocation above
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16528/#comment59420>
Shouldn't the newly-added page be replacing this?
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16528/#comment59419>
The selective use of camel-case is slightly jarring. Is there a convention you're following?
src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html
<https://reviews.apache.org/r/16528/#comment59415>
remove? seems superfluous
- Bill Farner
On Jan. 2, 2014, 10:48 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2014, 10:48 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
> src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 6, 2014, 9:46 p.m., Bill Farner wrote:
> > build.gradle, line 216
> > <https://reviews.apache.org/r/16528/diff/1-2/?file=407228#file407228line216>
> >
> > I actually meant to exec only once per file, passing another --gen arg:
> >
> > --gen java:hashcode --gen js
Didn't know that was an option. Thanks for pointing it out. Fixed it now.
> On Jan. 6, 2014, 9:46 p.m., Bill Farner wrote:
> > src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java, line 92
> > <https://reviews.apache.org/r/16528/diff/1-2/?file=407229#file407229line92>
> >
> > Does this mean ui/index.html is not served when i access /scheduler/? My quick read suggests the trailing slash will result in a 404.
Indeed it does. Will fix this tomorrow.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31268
-----------------------------------------------------------
On Jan. 7, 2014, 8:10 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 8:10 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31268
-----------------------------------------------------------
build.gradle
<https://reviews.apache.org/r/16528/#comment59661>
I actually meant to exec only once per file, passing another --gen arg:
--gen java:hashcode --gen js
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16528/#comment59662>
Does this mean ui/index.html is not served when i access /scheduler/? My quick read suggests the trailing slash will result in a 404.
- Bill Farner
On Jan. 3, 2014, 10:34 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2014, 10:34 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
> src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 15, 2014, 8:50 p.m., Bill Farner wrote:
> > Meant to ask this before, can you push this to origin so i can try it out locally? The binary files prevent me from pulling down a patch.
Done.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31922
-----------------------------------------------------------
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:08 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31922
-----------------------------------------------------------
Meant to ask this before, can you push this to origin so i can try it out locally? The binary files prevent me from pulling down a patch.
- Bill Farner
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:08 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
(Updated Jan. 17, 2014, 12:51 a.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Removed ability to select a row.
Bugs: AURORA-33
https://issues.apache.org/jira/browse/AURORA-33
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments
----------------
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 15, 2014, 11:58 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 26
> > <https://reviews.apache.org/r/16528/diff/5/?file=423857#file423857line26>
> >
> > I find this behavior jarring (clicking anywhere in a row takes you to a new page). Since the data in the table cell is already a link, can this be removed?
Removed.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31967
-----------------------------------------------------------
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:08 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31967
-----------------------------------------------------------
Ship it!
Looks great, mod one nit below.
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/16528/#comment60733>
I find this behavior jarring (clicking anywhere in a row takes you to a new page). Since the data in the table cell is already a link, can this be removed?
- Bill Farner
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:08 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 7:08 a.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Added TODOs.
Bugs: AURORA-33
https://issues.apache.org/jira/browse/AURORA-33
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments
----------------
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 14, 2014, 1:22 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java, line 20
> > <https://reviews.apache.org/r/16528/diff/3-4/?file=417936#file417936line20>
> >
> > thanks for fixing, this newline should actually be removed as well
>
> Suman Karumuri wrote:
> Looks like our style settings need to be tweaked after the org.apache rename. Removed.
You gave a ship-it on the review [1] where i globally fixed and explained this :-)
[1] https://reviews.apache.org/r/16576/
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31685
-----------------------------------------------------------
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:08 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 14, 2014, 1:22 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java, line 20
> > <https://reviews.apache.org/r/16528/diff/3-4/?file=417936#file417936line20>
> >
> > thanks for fixing, this newline should actually be removed as well
Looks like our style settings need to be tweaked after the org.apache rename. Removed.
> On Jan. 14, 2014, 1:22 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 85
> > <https://reviews.apache.org/r/16528/diff/4/?file=422214#file422214line85>
> >
> > This is a hack that i'd love to do without. The problem is this call:
> >
> > registerJerseyEndpoint(
> > "/scheduler/",
> > SchedulerzRole.class,
> > SchedulerzJob.class);
> >
> > The implementation of registerJerseyEndpoint no longer fits, which causes /scheduler/ to be picked up by GuiceContainer. The simplest path forward is probably to install SchedulerzRole and SchedulerzJob in a separate helper function that doesn't create this pattern overlap.
> >
Summarizing the discussion with Bill here.
There are other considerations but the issue boils down to the fact that angularJS resource loading breaks when the URL's end with a trailing / as outlined here https://github.com/angular/angular.js/issues/992
However, the servlets work even when the URL's end with a / which is not true for http resources. Instead of removing the trailing / for all URLs just removing it for the /scheduler path. Will add a TODO to remove it once all the servlet code is removed.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31685
-----------------------------------------------------------
On Jan. 13, 2014, 11:58 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 11:58 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 14, 2014, 1:22 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java, line 20
> > <https://reviews.apache.org/r/16528/diff/3-4/?file=417936#file417936line20>
> >
> > thanks for fixing, this newline should actually be removed as well
>
> Suman Karumuri wrote:
> Looks like our style settings need to be tweaked after the org.apache rename. Removed.
>
> Bill Farner wrote:
> You gave a ship-it on the review [1] where i globally fixed and explained this :-)
>
> [1] https://reviews.apache.org/r/16576/
:). I meant the intellij settings. Now I remember that I didn't install the settings jar you sent out via email, since Kevin said that it conflicts with science settings. Will do it now. I have manually edited my import config to fix this for the review.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31685
-----------------------------------------------------------
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:08 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31685
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java
<https://reviews.apache.org/r/16528/#comment60393>
thanks for fixing, this newline should actually be removed as well
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16528/#comment60394>
This is a hack that i'd love to do without. The problem is this call:
registerJerseyEndpoint(
"/scheduler/",
SchedulerzRole.class,
SchedulerzJob.class);
The implementation of registerJerseyEndpoint no longer fits, which causes /scheduler/ to be picked up by GuiceContainer. The simplest path forward is probably to install SchedulerzRole and SchedulerzJob in a separate helper function that doesn't create this pattern overlap.
- Bill Farner
On Jan. 13, 2014, 11:58 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 11:58 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 11:58 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Added a redirect filter to fix "/scheduler/" 404. Addressed code review nits.
Bugs: AURORA-33
https://issues.apache.org/jira/browse/AURORA-33
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments
----------------
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 7:32 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-33
https://issues.apache.org/jira/browse/AURORA-33
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments
----------------
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > build.gradle, line 206
> > <https://reviews.apache.org/r/16528/diff/3/?file=417935#file417935line206>
> >
> > Feel free to omit this comment. I find the behavior pretty obvious from the args.
Done.
> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > build.gradle, line 214
> > <https://reviews.apache.org/r/16528/diff/3/?file=417935#file417935line214>
> >
> > revert
Done.
> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 198
> > <https://reviews.apache.org/r/16528/diff/3/?file=417938#file417938line198>
> >
> > I'm usually a fan of inlining functions where the body is one line and there's a single caller — less code overall.
> >
> > Ditto below.
Done.
> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 26
> > <https://reviews.apache.org/r/16528/diff/3/?file=417945#file417945line26>
> >
> > Looks like leftover testing code. Please remove.
I left the mocks intentionally so I can use it in the stand alone UI. Removed it now.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31390
-----------------------------------------------------------
On Jan. 7, 2014, 8:10 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 8:10 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31390
-----------------------------------------------------------
build.gradle
<https://reviews.apache.org/r/16528/#comment59850>
Feel free to omit this comment. I find the behavior pretty obvious from the args.
build.gradle
<https://reviews.apache.org/r/16528/#comment59851>
revert
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16528/#comment59852>
I'm usually a fan of inlining functions where the body is one line and there's a single caller — less code overall.
Ditto below.
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
<https://reviews.apache.org/r/16528/#comment59853>
Looks like leftover testing code. Please remove.
- Bill Farner
On Jan. 7, 2014, 8:10 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 8:10 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
> On Jan. 8, 2014, 8:11 p.m., Bill Farner wrote:
> > Would you mind moving the relevant ticket to apache jira as well?
Moved the jira task to Apache repo.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31389
-----------------------------------------------------------
On Jan. 13, 2014, 7:32 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 7:32 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31389
-----------------------------------------------------------
Would you mind moving the relevant ticket to apache jira as well?
- Bill Farner
On Jan. 7, 2014, 8:10 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 8:10 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
>
> The URLs in the new UI will redirect to the scheduler role pages.
>
> Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
>
> Cleaned up the UI to make it more light weight.
>
> Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
>
> Updated build.gradle to generate thrift JS client.
>
> Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
> 3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
> 3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
> 3rdparty/javascript/thrift.js PRE-CREATION
> build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
> src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
> src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
> src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16528/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
> Tested the UI using the isolated scheduler.
>
>
> File Attachments
> ----------------
>
> Home page
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
(Updated Jan. 7, 2014, 8:10 a.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Removed code for old home page as requested.
Rebased with master.
Moved assets in com/twitter -> org/apache.
Fixed code review comments.
/scheduler/ results in 404 in this code. Will fix it.
Sending out a review, so Bill and others can run this patch locally to get additional feedback on UI and UX.
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java d775edeae93d61850a8619a6675699560e941277
src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 263591a1a387731be11936a7ad244cdc81b40a10
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java a3faf6be3635ec4f985867dd4598ad434a985fb7
src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 5e540f303ffa3d057dea564b394a29508b03c03c
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments
----------------
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
(Updated Jan. 3, 2014, 10:34 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
moved the new ui to scheduler/.
Adressed code review feedback for build.gradle.
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments
----------------
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
(Updated Jan. 2, 2014, 10:48 p.m.)
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments
----------------
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
Re: Review Request 16528: Scheduler home page new using AngularJS and UI
client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
-----------------------------------------------------------
(Updated Dec. 31, 2013, 10:30 a.m.)
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Changes
-------
Added a screenshot of the new home page.
Repository: aurora
Description
-------
Implemented new Scheduler home page using AngularJS. The UI queries the backend using the thrift end point. This diff sets the basic foundation for the page. Sending this out to get some early feedback and to keep the future diffs small.
The URLs in the new UI will redirect to the scheduler role pages.
Dropped the option to select number of results to be shown to simplify the interface. Now defaulting to 25 results per page.
Cleaned up the UI to make it more light weight.
Added a mock service to render dummy data on the page. Currently, this mock service is manually wired during testing. Will created an isolated scheduler page once we have a single page app.
Updated build.gradle to generate thrift JS client.
Installed Angular and smart-table from bower. Added thrift.js file to make the calls to the backend. Will migrate to angular-thrift for more robust implementation in coming diffs.
Diffs
-----
3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle 7e33ed8c7c6f118908d24cb5a7e3a8a15e34e063
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 825e2e1eb442feb2bac1d8d7df20707fd23fc23d
src/main/resources/com/twitter/aurora/scheduler/http/ui/css/app.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/index.html PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/controllers.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/directives.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/js/services.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/ui/roleLink.html PRE-CREATION
Diff: https://reviews.apache.org/r/16528/diff/
Testing
-------
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments (updated)
----------------
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri